GasLimit to 0 #46
Merged
GasLimit to 0 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* channel: Include shared Nonce object, incrementing the nonce of an account while the transaction is broadcast. Implement sync.Mutex, locking the nonce incrementals. In erc20_depositor.go, the depositing process is locked during the "Approve" function call with ```lockKey```. The function ```(d *ERC20Depositor) Deposit``` is renamed to `````(d *ERC20Depositor) DepositOnly` * client: To avoid timeouts caused by the added locking mechanism during ERC20 deposits, ```context.WithTimeout``` and ```twoPartyTestTimeout``` has been increased in fund_test.go and payment_test.go. * client/test: Timeouts have been increased to avoid premature timeout errors due to the locking mechanism above. --------- Signed-off-by: Ilja von Hoessle <ilja@perun.network> Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
Remove unused SharedNonceMtx. Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
refactor(erc20_depositor): - Create seperate function for Approval. - Rename lock and mutex. Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
- Add description to Approve function. - Put Error as last return element in Approve function. fix(erc20_depositor): - remove unnecessary locking of depositLocksMtx. Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
Fix comment and Argument order for Linter. Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
so that it is dynamically calculated by the wallet. Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
Co-authored-by: Philipp Lehwalder <philipp.lehwalder@gmail.com> Signed-off-by: Sophia <118169531+sophia1ch@users.noreply.github.com> Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
- Change SharedMutex to SharedExpectedNoncesMutex. refactor(erc20_depositor): - Return directly if Approval returns error. - Fix comments. Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
Change position of bracket. Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
- GasLimit is set when adjudicator and depositors are created. - This way we can differentiate between tests and production. Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
sophia1ch
force-pushed
the
fix-gaslimit
branch
from
7d8a144
to
89f7b83
Compare
Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
Signed-off-by: Sophia <118169531+sophia1ch@users.noreply.github.com>
Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
iljabvh
reviewed
Feb 20, 2024
channel/funder_test.go
Outdated
| // Use an ERC20 depositor with random addresses at index 1. | ||
| token := wallettest.NewRandomAddress(rng) | ||
| depositors[1] = ethchannel.NewERC20Depositor(ethwallet.AsEthAddr(token)) | ||
| depositors[1] = ethchannel.NewERC20Depositor(ethwallet.AsEthAddr(token), 100000) |
There was a problem hiding this comment.
This gaslimit value is already defined above as txGasLimit. You can use that value.
In fact, both depositors, the NewETHDepositor and the NewERC20Depositor could use constants defined above: Instead of txGasLimit, you can set txERC20GasLimit and txETHGasLimit for both cases, with 100000 and 50000, respectively.
Signed-off-by: Sophia Koehler <sophia@perun.network>
iljabvh
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR sets the GasLimit to a given argument in the ERC20_Depositor, ETH_Depositor and ContractBackend. This allows us to set the gas limit to 0 for all chains that support the dynamic gasLimit estimation.