Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onChanOpenInit and onChanOpenTry to returns a module address #300

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix onChanOpenInit and onChanOpenTry to returns a module address #300

merged 2 commits into from
Sep 30, 2024

Conversation

bluele
Copy link
Member

@bluele bluele commented Sep 30, 2024 •
edited
Loading

Overview

Previously, the module contract bound to the port using bindPort would hold the state of all channels, but this change allows you to create a contract for each channel using onChanInit or onChanTry callbacks.

Breaking Changes

  • Changes to the return values of functions onChanInit and onChanTry of IIBCModule

@bluele
fix onChanOpenInit and onChanOpenTry to returns a module address
e6b4faa 
Signed-off-by: Jun Kimura <jun.kimura@datachain.jp>
@bluele
improve tests
d551cd7 
Signed-off-by: Jun Kimura <jun.kimura@datachain.jp>
@bluele bluele marked this pull request as ready for review September 30, 2024 05:30
@bluele bluele requested a review from a team as a code owner September 30, 2024 05:30
@bluele bluele merged commit ca7a56c into main Sep 30, 2024
6 checks passed
@bluele bluele deleted the fix-module-initializer-return-address branch September 30, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bluele