Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel upgrade #143

Merged
merged 47 commits into from
Aug 30, 2024
Merged

Channel upgrade #143

merged 47 commits into from
Aug 30, 2024

Conversation

siburu
Copy link
Contributor

@siburu siburu commented Jun 28, 2024

No description provided.

@siburu siburu force-pushed the channel-upgrade branch 3 times, most recently from 6b07d01 to 1803ad8 Compare July 9, 2024 05:59
@siburu siburu force-pushed the channel-upgrade branch 4 times, most recently from 70cba96 to 6d53f43 Compare July 25, 2024 13:21
@siburu siburu force-pushed the channel-upgrade branch 4 times, most recently from 1f0dcde to 4130557 Compare August 20, 2024 19:27
@siburu
refactor connection/channel handshake implementations
aa2fff3 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
bluele
bluele reviewed Aug 26, 2024
View reviewed changes
cmd/tx.go Outdated Show resolved Hide resolved
bluele
bluele reviewed Aug 26, 2024
View reviewed changes
cmd/query.go Outdated Show resolved Hide resolved
bluele
bluele reviewed Aug 26, 2024
View reviewed changes
core/channel-upgrade.go Outdated Show resolved Hide resolved
bluele
bluele reviewed Aug 26, 2024
View reviewed changes
core/channel-upgrade.go Outdated Show resolved Hide resolved
bluele
bluele reviewed Aug 27, 2024
View reviewed changes
core/relayMsgs.go Outdated Show resolved Hide resolved
@siburu siburu marked this pull request as ready for review August 29, 2024 22:44
@siburu siburu requested a review from a team as a code owner August 29, 2024 22:44
@siburu siburu requested a review from bluele August 29, 2024 22:44
bluele
bluele reviewed Aug 30, 2024
View reviewed changes
config/core.go Show resolved Hide resolved
bluele
bluele reviewed Aug 30, 2024
View reviewed changes
core/relayMsgs.go Outdated Show resolved Hide resolved
bluele
bluele reviewed Aug 30, 2024
View reviewed changes
core/channel-upgrade.go Outdated Show resolved Hide resolved
bluele
bluele reviewed Aug 30, 2024
View reviewed changes
core/channel-upgrade.go Outdated Show resolved Hide resolved
bluele
bluele approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@bluele bluele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM👍

@siburu
add connectionID argument to Chain::QueryConnection method
0232e18 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
update the path config fields (connection-id, version and order) when…
49f72d4 
… channel upgrade is successfully completed

Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
fix test-channel-upgrade to test the path config update feature
2be31c2 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
minor fix of test-create-xxx
e802418 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
minor fix of test-channel-upgrade
1bae6e3 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
output a WARN log when executing chanUpgradeCancel without error receipt
432d60f 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
brush up channel-upgrade execute subcommand
974ff9f 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
add ibc-mock-app to simd
f304f82 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
use mockapp instead of ics20 in tm2tm test
3a44e81 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
add more test cases to test-channel-upgrade
5ea24b4 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
add more test cases related to timeout
3d197e4 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
remove upgradeSequence parameter of Chain::QueryChannelUpgradeError
5763813 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
add yrly query channel-upgrade subcommand
a60f6e2 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
delete use of logger.With in upgradeChannelStep
f776f94 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
add log outputs in channel upgrade functions
b25de5e 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
modify {Init,Cancel}ChannelUpgrade to just send a msg and not to wait…
315bb5a 
… for the finality of it

Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
add the --unsafe flag to the tx channel-upgrade init subcommand
eaec52a 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
finish the command successfully if channel upgrade states are transit…
0e7d2b3 
…ioning to UNINIT+UNINIT before sending the first tx

Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
fix a bug in tx channel-upgrade init
b65f836 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
fix tx query client|connection|channel|channel-upgrade to return an…
8ec8a0a 
… error if it fails to marshal the state

Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
brush up and fix logics of checkChannelFinality and checkConnectionFi…
8479e6c 
…nality

Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
fix query channel-upgrade subcommand to print the zero-value Upgrad…
5f042f2 
…e if upgrade not found

Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
fix CancelChannelUpgrade to wait for state settlement and to send Msg…
382b372 
…UpdateClient if necessary

Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
fix CancelChannelUpgrade to avoid using multicall
b1b5e66 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
fix logging in RelayMsgs
94e2251 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
fix CancelChannelUpgrade to stop waiting before the first attempt
311828e 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
fix updateChannelStep to add the first_call attribute in log outputs
67a5da8 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
fix msgsToLoggable
d02879e 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu
improve the loop in ExecuteChannelUpgrade
dc23bc2 
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
@siburu siburu merged commit 94e7b78 into hyperledger-labs:main Aug 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluele bluele bluele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siburu @bluele