Fix recursive struct issue #1522
Conversation
LucasSte
force-pushed
the
recursive-struct
branch
from
b351eef to
373e3b0
Compare
LucasSte
force-pushed
the
recursive-struct
branch
from
373e3b0 to
c3aeba6
Compare
| Type::Array(_, dims) if dims.contains(&ArrayLength::Dynamic) => { | ||
| let size = dynamic_array_size(dims); | ||
| // A pointer is four bytes on Solana | ||
| size * 4 |
There was a problem hiding this comment.
Wouldn't this be the size + 4 times the number of dynamic arrays?
There was a problem hiding this comment.
As I understand, an array uint8 [2][][3] means a fixed-length array of pointers that contains three elements. Each pointer points to uint8[2]. The size will only be 3*pointer_size. Now if the type was uint8 [2][][][3], we'll still have a fixed-array of pointers that contains three elements. Each pointer points to a uint8[2][]. The size will continue to be 3*pointer_size.
The function calculates the minimum size we need for storage. As soon as we allocate elements, more space will be necessary.
There was a problem hiding this comment.
I see, thanks.
What you explained here would look good in a comment to the source code (or even in the doc comment of this function)
There was a problem hiding this comment.
This is explained right above dynamic_array_size between lines 2172 and 2176.
LucasSte
force-pushed
the
recursive-struct
branch
from
c3aeba6 to
ebf2056
Compare
| Type::Array(_, dims) if dims.contains(&ArrayLength::Dynamic) => { | ||
| let size = dynamic_array_size(dims); | ||
| // A pointer is four bytes on Solana | ||
| size * 4 |
There was a problem hiding this comment.
I see, thanks.
What you explained here would look good in a comment to the source code (or even in the doc comment of this function)
Signed-off-by: Lucas Steuernagel <lucas.tnagel@gmail.com>
LucasSte
force-pushed
the
recursive-struct
branch
from
ebf2056 to
9c9ddb9
Compare
Structs that contains themselves in a dynamic array are not recursive and do not have infinite size, as in the example below: