Allow using {func} for type to use library functions #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
reviewed
Sep 15, 2023
LucasSte
reviewed
Sep 15, 2023
xermicus
reviewed
Sep 19, 2023
| @@ -74,7 +74,7 @@ fn using() { | |||
| let mut runtime = build_solidity( | |||
| r##" | |||
| contract test { | |||
| using ints for uint32; | |||
There was a problem hiding this comment.
This potentially reduces test coverage, or is it tested in another place anyways?
There was a problem hiding this comment.
This is already tested above (line 50 to 70)
src/sema/namespace.rs
Outdated
| @@ -376,7 +377,7 @@ impl Namespace { | |||
| .map(|(id, namespace)| (id, namespace.iter().collect())) | |||
| .unwrap(); | |||
|
|
|||
| let s = self.resolve_namespace(namespace, file_no, None, id, diagnostics)?; | |||
| let s = self.resolve_namespace(namespace, file_no, contract_no, id, diagnostics)?; | |||
There was a problem hiding this comment.
Not to be pedantic, but just s is a bad variable name
There was a problem hiding this comment.
Not to be pedantic, but just
sis a bad variable name
I agree
There was a problem hiding this comment.
Renamed to symbol
LucasSte
approved these changes
Sep 19, 2023
src/sema/namespace.rs
Outdated
| @@ -376,7 +377,7 @@ impl Namespace { | |||
| .map(|(id, namespace)| (id, namespace.iter().collect())) | |||
| .unwrap(); | |||
|
|
|||
| let s = self.resolve_namespace(namespace, file_no, None, id, diagnostics)?; | |||
| let s = self.resolve_namespace(namespace, file_no, contract_no, id, diagnostics)?; | |||
There was a problem hiding this comment.
Not to be pedantic, but just
sis a bad variable name
I agree
Comment on lines
+273
to
+281
| if dummy | ||
| .cast( | ||
| &loc, | ||
| &func.params[0].ty, | ||
| true, | ||
| ns, | ||
| &mut Diagnostics::default(), | ||
| ) | ||
| .is_err() |
There was a problem hiding this comment.
Is there any test in which we are casting the first argument for the library call?
There was a problem hiding this comment.
The polkadot test does this
Fixes hyperledger-solang#1525 Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Sean Young <sean@mess.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1525