add hint to install ninja #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nadeem Bhati <nadeemb53@gmail.com>
nadeemb53
requested review from
seanyoung,
xermicus and
LucasSte
as code owners
seanyoung
approved these changes
Sep 19, 2023
LucasSte
reviewed
Sep 19, 2023
docs/installing.rst
Outdated
| @@ -167,7 +167,7 @@ Building LLVM from source | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| The LLVM project itself has a guide to `installing from source <http://www.llvm.org/docs/CMake.html>`_ which | |||
| you may need to consult. First of all clone our LLVM repository: | |||
| you may need to consult. You might need to `install Ninja <https://ninja-build.org>`_. First of all clone our LLVM repository: | |||
There was a problem hiding this comment.
The installation command uses Ninja, so I would not use might here. A better wording would be:
Ninja is necessary for building LLVM from source.
xermicus
approved these changes
Sep 19, 2023
Signed-off-by: Nadeem Bhati <nadeemb53@gmail.com>
LucasSte
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.