Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fresh clippy lints #1621

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Fix fresh clippy lints #1621

merged 2 commits into from
Jan 31, 2024

Conversation

xermicus
Copy link
Contributor

No description provided.

@xermicus
fix new lints
c99ee32 
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
@xermicus
fix
4998f61 
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
@xermicus
Copy link
Contributor Author

I'm not exactly sure why CI fails, the only thing this PR does is changing some lines of code without changing any semantics.

seanyoung
seanyoung approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@seanyoung seanyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those build failures are unrelated to your changes

@xermicus xermicus mentioned this pull request Jan 31, 2024
Merged
@xermicus xermicus merged commit b6b2fc9 into hyperledger-solang:main Jan 31, 2024
16 of 18 checks passed
@xermicus xermicus deleted the clippies branch January 31, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasSte LucasSte LucasSte approved these changes

@seanyoung seanyoung seanyoung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xermicus @seanyoung @LucasSte