fixes #2127 - do not use a separate counter for batch ids #2128
+38
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shohou
force-pushed
the
2127_request_id
branch
from
bfc7dc1 to
21d719b
Compare
|
@Shohou Can you please add DCO to all your commits. |
Shohou
force-pushed
the
2127_request_id
branch
2 times, most recently
from
a0dcc69 to
39f95b9
Compare
|
@NickSneo done |
|
@Shohou please check the pipeline status messages |
…ch ids, take the one used for requests Signed-off-by: Dmitry Shohov <shohou@gmail.com>
Shohou
force-pushed
the
2127_request_id
branch
from
39f95b9 to
346dd6a
Compare
|
@gtebrean fixed test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of having a separate counter for batch ids, take the one used for requests
What does this PR do?
fixes #2127
Where should the reviewer start?
At WebSocketService.java
Why is it needed?
to fix #2127
Checklist