fix: do not free string #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <timo@animo.id>
|
One thing I'm curious about: Do we also need to modify the calls to string_free in the RN wrapper? I think it's probably different as there's no automatic GC? |
For React Native I think it is good to keep freeing it manually, considering that the only thing we do there is assigning a pointer. In Node.js I'm still not too convinced the way it works, but apparently it does some magic that makes this fix important to not double freeing memory. |
|
Are you okay with the changes in this PR @genaris? We should add you to the maintainers list |
genaris
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in this PR" openwallet-foundation/credo-ts#1606