AnonCreds Credentials using the W3C Standard - proof value encoding #276
Conversation
Artemkaaas
force-pushed
the
anoncreds-w3c-encoding
branch
from
530696a
to
2bb5960
Compare
Artemkaaas
force-pushed
the
anoncreds-w3c-encoding
branch
3 times, most recently
from
ad534b8
to
9b2bffe
Compare
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
Artemkaaas
force-pushed
the
anoncreds-w3c-encoding
branch
from
9b2bffe
to
2a7cbe6
Compare
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
Artemkaaas
force-pushed
the
anoncreds-w3c-encoding
branch
from
0931816
to
f99386a
Compare
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
# Conflicts: # src/data_types/w3c/credential_proof.rs # src/data_types/w3c/mod.rs # src/data_types/w3c/presentation_proof.rs # src/services/w3c/credential_conversion.rs # src/services/w3c/issuer.rs # src/services/w3c/prover.rs # tests/anoncreds_demos.rs
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
…anoncreds-w3c-encoding # Conflicts: # src/data_types/w3c/proof.rs # src/services/w3c/verifier.rs
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
…anoncreds-w3c-encoding # Conflicts: # src/data_types/w3c/proof.rs # src/services/w3c/credential_conversion.rs # src/services/w3c/prover.rs
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
Artemkaaas
force-pushed
the
anoncreds-w3c-encoding
branch
from
f04293e
to
7c4d90f
Compare
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
Artemkaaas
force-pushed
the
anoncreds-w3c-encoding
branch
from
b82eee6
to
1e0f32b
Compare
|
Tests are failing because a Rust dependency now requires 1.66 or higher. We can either update the CI rust version or add a lockfile in another PR. |
|
Seems like updating would be the prudent thing? What is typically done in this situation? How much risk is bumping the rust version? As I recall — the. #295 is failing one test (Android) because it needs 1.70. Should we bump to that? |
|
There's no real risk in bumping the Rust version used, it just means that we can't guarantee compatibility with older versions. I think the Android failure is different (one of cross's dependencies), and partly fixed by this PR, but it would eventually need a lockfile to maintain its platform support. |
|
OK — just trying to figure out how we get to a decision/action on this. Who makes the call? |
|
@berendsliedrecht just checking if this can impose a problem for the supported versions of the RN wrapper if the version is bumped? |
…anoncreds-w3c-encoding Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com> # Conflicts: # src/data_types/w3c/proof.rs # src/services/w3c/credential_conversion.rs # src/services/w3c/issuer.rs # src/services/w3c/prover.rs # src/services/w3c/verifier.rs
|
@Artemkaaas --- sorry to be a pain. Looks like we have one unit test failing. Could you please take a look?
Fails on both Ubuntu and Windows. |
Signed-off-by: artem.ivanov <artem.ivanov@dsr-corporation.com>
Artemkaaas
force-pushed
the
anoncreds-w3c-encoding
branch
from
e7e9ace
to
63e7085
Compare
Use message pack for encoding proof values of w3c credentials and presentation.
Results of proof value string length on example of credentials signature: