fix: Incorrect SQLite expire check #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkulic
force-pushed
the
fix/sqlite_expire_check
branch
from
aa66157
to
a335a2a
Compare
Signed-off-by: Darko Kulic <darko.kulic@sicpa.com>
dkulic
force-pushed
the
fix/sqlite_expire_check
branch
from
a335a2a
to
a444b60
Compare
jamshale
pushed a commit
to jamshale/aries-askar
that referenced
this pull request
Aug 18, 2024
fix: Incorrect SQLite expire check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SQLite comparison of expiry date is done using query
but SQLite considers text strings for date and time comparisons by character order, not by their actual date/time value., so the check is not working correctly and askar returns the items stored even after expired.
The fix is easy,
expiryshould be first converted to DATETIME, in above query something like:Fixes issue #260