update secure-env to 0.5 #289
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
berendsliedrecht
commented
Jul 25, 2024
berendsliedrecht
commented
- DRAFT: using CI to build the libraries
berendsliedrecht
force-pushed
the
update-secure-env
branch
from
d818753
to
06e957a
Compare
Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>
berendsliedrecht
force-pushed
the
update-secure-env
branch
from
06e957a
to
2819875
Compare
swcurran
reviewed
Jul 25, 2024
| @@ -101,7 +101,7 @@ p384 = { version = "0.13", default-features = false, features = [ | |||
| "ecdh", | |||
| ], optional = true } | |||
| rand = { version = "0.8", default-features = false } | |||
| secure-env = { package = "animo-secure-env", version = "0.4", optional = true } | |||
| secure-env = { package = "animo-secure-env", version = "0.5", optional = true } | |||
There was a problem hiding this comment.
Just as a matter of interest — what is the animo-secure-env?
There was a problem hiding this comment.
It allows hardware backed key generation and signing on iOS / android. We should probably have chosen a more descriptive name :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.