fix: version should be set by pyproject.toml #2471
Conversation
dbluhm
force-pushed
the
fix/version-read-from-pyproject
branch
from
50c6b89
to
996d17a
Compare
|
Dang — I didn’t get the memo about that addition. I’ll update the “Publishing.md” doc to add that. However, in that document, I did say double check that there is not the version somewhere else so I should have caught it… 🦤 Bigger question — does this mean we need to do a 0.10.2 to get this properly published? |
|
@swcurran No, 0.10.1 is valid since it was published before we merged the poetry PR. So no changes required for the release. |
|
Of course. Phewww…. I didn’t mess up :-) |
dbluhm
dismissed stale reviews from usingtechnology and swcurran
via
d1dc71e
dbluhm
force-pushed
the
fix/version-read-from-pyproject
branch
from
996d17a
to
d1dc71e
Compare
|
@swcurran @usingtechnology Sorry, fixing the conflicts on poetry.lock dismissed your reviews -- this should be ready to merge now though! |
|
I need to resolve issues in integration tests. My path to the pyproject.toml is bad. This isn't urgent (until we start preparing for another release) so I'll mark this as a draft and we can get some of the other pending PRs merged first. |
dbluhm
force-pushed
the
fix/version-read-from-pyproject
branch
from
d1dc71e
to
bc9a7e2
Compare
`aries_cloudagent.version.__version__` was out of sync with the version listed in the pyproject.toml file. The pyproject.toml file should be the source of truth as it will be used when publishing using poetry. However, `__version__` is used in code for some operations. To ensure that the pyproject file and the `__version__` can't get out of sync, `aries_cloudagent.version` will now read from the package metadata to obtain the version. Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
dbluhm
force-pushed
the
fix/version-read-from-pyproject
branch
from
bc9a7e2
to
492091e
Compare
|
@usingtechnology @swcurran this is ready for another review. |
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
|
Kudos, SonarCloud Quality Gate passed!
|
aries_cloudagent.version.__version__was out of sync with the version listed in the pyproject.toml file. The pyproject.toml file should be the source of truth as it will be used when publishing using poetry. However,__version__is used in code for some operations. To ensure that the pyproject file and the__version__can't get out of sync,aries_cloudagent.versionwill now be read from the package metadata.Update: I was previously trying to read from pyproject.toml. This was a naive approach that wouldn't have worked after installing ACA-Py as a pip package. The better solution is the one I've switched to, just reading the package metadata.