Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct rust log level in dockerfiles #2499

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

loneil
Copy link
Contributor

@loneil loneil commented Sep 21, 2023

From issue #2498

It looks like warning is not a valid Rust log level string https://docs.rs/log/latest/log/enum.Level.html
From what I've seen in traction (which deploys using the dockerfile here), this means logs default to INFO level here even though dockerfile is trying to have it at the warn level. (see details in ticket for what I tried out)

Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@loneil
Copy link
Contributor Author

loneil commented Sep 21, 2023

I suppose if anyone is using this dockerfile and counting on having the INFO level logs come out (even though they're not supposed to) they would be missing those after updating to a version including this fix. But in that case one should be setting their own deployment to INFO anyways...

@swcurran swcurran merged commit 0867ad1 into hyperledger:main Sep 21, 2023
9 checks passed
@loneil loneil deleted the bugfix/dockerfileRustLog branch November 20, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants