Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: taa rough timestamp timezone from datetime #2554

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: taa rough timestamp timezone from datetime #2554

merged 1 commit into from
Oct 18, 2023

Conversation

dbluhm
Copy link
Member

@dbluhm dbluhm commented Oct 18, 2023

Fixes #2553

@dbluhm
fix: taa rough timestamp timezone from datetime
12ec11b 
Fixes hyperledger#2553

Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

swcurran
swcurran approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbluhm
Copy link
Member Author

dbluhm commented Oct 18, 2023

Integration test failure but I don't think it's caused by these changes. Rerunning. I'll monitor to see if it happens again.

@dbluhm dbluhm merged commit bf871f7 into hyperledger:main Oct 18, 2023
9 checks passed
@dbluhm dbluhm deleted the fix/taa-rough-timestamp branch October 18, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swcurran swcurran swcurran approved these changes

@usingtechnology usingtechnology usingtechnology approved these changes

@andrewwhitehead andrewwhitehead Awaiting requested review from andrewwhitehead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: error on TAA accept endpoint
3 participants
@dbluhm @swcurran @usingtechnology