Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #2589 TypeError When There Are No Nested Requirements #2590

Conversation

Ennovate-com
Copy link
Contributor

Added if statement, same as in calling function create_vp, to the called function apply_requirements. Since the former calls apply_requirements in both cases (if req.nested_req or not), the called function should handle both cases as well.

Signed-off-by: Robert Simpson <RobS.git9@MailScreen.com>
@dbluhm dbluhm force-pushed the fix/TypeError_when_no_nested_requirements branch from 4366643 to abd79bb Compare November 3, 2023 16:59
@dbluhm dbluhm enabled auto-merge November 3, 2023 16:59
Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dbluhm dbluhm merged commit e133396 into hyperledger:main Nov 3, 2023
8 checks passed
@Ennovate-com Ennovate-com deleted the fix/TypeError_when_no_nested_requirements branch December 25, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants