chore: correct type hints on base record #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small tweak to correct the type hints on base record and related base classes. These are base classes used widely both within ACA-Py and in plugins. Having these types corrected will solve a cascade of static type checking errors. These aren't strictly necessary errors to fix but they sure make my life as a developer easier. Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
|
Kudos, SonarCloud Quality Gate passed!
|
swcurran
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small tweak to correct the type hints on base record and related base classes. These are base classes used widely both within ACA-Py and in plugins. Having these types corrected will solve a cascade of static type checking errors.
These aren't strictly necessary errors to fix but they sure make my life as a developer easier.