Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for did:peer #2713

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Integration test for did:peer #2713

merged 6 commits into from
Jan 16, 2024

Conversation

ianco
Copy link
Member

@ianco ianco commented Jan 15, 2024

See issue #2703

Adds a (failing) test for --emit-did-peer-x (not included in regular GHA run)

Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
@ianco ianco requested a review from Jsyro January 15, 2024 20:46
@ianco
Copy link
Member Author

ianco commented Jan 15, 2024

Piggy-backing a couple of demo updates - the ability to provide extra agent args (same way as is implemented in the BDD tests) and also to override the ports used by the demo (and BDD) agents.

demo/README.md Outdated Show resolved Hide resolved
swcurran
swcurran previously approved these changes Jan 15, 2024
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Copy link
Contributor

@Jsyro Jsyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. just one personal comment.

Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ianco ianco merged commit a7edc73 into hyperledger:main Jan 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants