fix: rev notifications on publish pending #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hyperledger#2915. Ensure revocation notifications are emitted when publishing batched pending revocations. Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
|
jamshale
reviewed
Apr 25, 2024
| @@ -294,6 +295,9 @@ async def publish_pending_revocations( | |||
| ) | |||
| else: | |||
| rev_entry_resp = await issuer_rr_upd.send_entry(self._profile) | |||
There was a problem hiding this comment.
Before I removed this it had a if not connection_id: statement on this. I think that's partly what confused me initially before I got more familiar with the flow.
jamshale
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2915.
Ensure revocation notifications are emitted when publishing batched pending revocations when not using an external endorser to publish the transaction.