-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Upgrade pydid (pydantic v2) #2919
Conversation
@ff137 I think this should be ready for review now; would you be able to regenerate the lock file? |
@dbluhm Nice! I missed that 0.5.0 was released. I'll rebase 👍 One thing to keep in mind is that the acapy-plugins will need to also be upgrade to pydantic v2, to ensure compatibility. |
I don't think it would affect DRPC |
FWIW the redis-events plugin uses pydantic v1, and we did an upgrade for that when testing this release. So I can contribute pydantic V2 for that one plugin. Can help with the others too, because I've memorised a lot of the migration steps :-) |
Yes. I think some plugins will need to be updated. I know the oid4vci plugin has a pydantic dependency. We have the release management system merged for the plugin repo just now, so the upgrades could be prepared and then merged after the aca-py release. |
This is why the release management should help. If we don't update a plugin and retire it. It is now tagged with 0.12.1 (All plugins are currently passing). It can just be left behind unless we chose to upgrade it. No need to remove it or anything. |
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Quality Gate passedIssues Measures |
Testing pydid upgrade to pydantic v2: Indicio-tech/pydid#72
Edit: Great! All checks have passed. Marking as draft until pydid update is released