Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade pydid (pydantic v2) #2919

Merged
merged 3 commits into from
May 15, 2024

Conversation

ff137
Copy link
Contributor

@ff137 ff137 commented Apr 26, 2024

Testing pydid upgrade to pydantic v2: Indicio-tech/pydid#72

Edit: Great! All checks have passed. Marking as draft until pydid update is released

@ff137 ff137 marked this pull request as draft April 26, 2024 12:44
@dbluhm dbluhm added the 1.0.0 To be addressed for the ACA-Py 1.0.0 release label May 14, 2024
@dbluhm dbluhm marked this pull request as ready for review May 14, 2024 18:36
@dbluhm
Copy link
Contributor

dbluhm commented May 14, 2024

@ff137 I think this should be ready for review now; would you be able to regenerate the lock file?

@ff137
Copy link
Contributor Author

ff137 commented May 14, 2024

@dbluhm Nice! I missed that 0.5.0 was released. I'll rebase 👍

One thing to keep in mind is that the acapy-plugins will need to also be upgrade to pydantic v2, to ensure compatibility.

@dbluhm
Copy link
Contributor

dbluhm commented May 15, 2024

@jamshale @amanji heads up on @ff137's point. Do you anticipate any challenges with the plugins you maintain?

I think there would be a conflict with the pickup plugin we maintain. We haven't done major updates to that plugin in a while though so maybe it's just time to retire it.

@amanji
Copy link
Contributor

amanji commented May 15, 2024

I don't think it would affect DRPC

@ff137
Copy link
Contributor Author

ff137 commented May 15, 2024

FWIW the redis-events plugin uses pydantic v1, and we did an upgrade for that when testing this release. So I can contribute pydantic V2 for that one plugin. Can help with the others too, because I've memorised a lot of the migration steps :-)

@jamshale
Copy link
Contributor

Yes. I think some plugins will need to be updated. I know the oid4vci plugin has a pydantic dependency.

We have the release management system merged for the plugin repo just now, so the upgrades could be prepared and then merged after the aca-py release.

@jamshale
Copy link
Contributor

This is why the release management should help. If we don't update a plugin and retire it. It is now tagged with 0.12.1 (All plugins are currently passing). It can just be left behind unless we chose to upgrade it. No need to remove it or anything.

ff137 added 3 commits May 15, 2024 20:44
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ff137
Copy link
Contributor Author

ff137 commented May 15, 2024

@dbluhm I'm eager to get this one merged 😄 because there's a rebase-and-wait-for-tests loop to go through for #2939 and #2940 as well. Maybe I can merge those 2 into 1 PR, if it's alright with you

@dbluhm dbluhm merged commit fedf2b8 into openwallet-foundation:main May 15, 2024
8 checks passed
@ff137 ff137 deleted the test-pydid-upgrade branch July 4, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 To be addressed for the ACA-Py 1.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants