Fix issue with requested to revoke before registry creation #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamshale <jamiehalebc@gmail.com>
|
|
@cvarjao — this might be the source of the issue with some Lawyers being unable to produce a valid revocation proof. If this same issue is happening in Credo, the result would be the “accum_to” being “NONE”, which IIRC was the error that was coming up. Further, if the lawyer got a new credential, their existing credential would be revoked, triggering an update of the RevReg, which might in turn would make the problem go away. |
dbluhm
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2962 by fetching the registry list start time and then using it for the revoke_to value and recalculating the delta, when the
accum_tovalue is missing from the ledger response. This means that if the presentation request has a revoke_to value before the registry was created that the holder will use the creation time to calculate the delta.There is some conversation about the desired behaviour in the ticket. I'm not certain this is the way it should be fixed, but my limited understand and testing appears like it is valid.