Add rekey feature with blank key support #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamshale <jamiehalebc@gmail.com>
esune
reviewed
Jul 26, 2024
|
rekey derivation method support has been added. |
esune
previously approved these changes
Jul 26, 2024
kukgini
reviewed
Jul 29, 2024
kukgini
reviewed
Jul 29, 2024
kukgini
reviewed
Jul 29, 2024
Signed-off-by: jamshale <jamiehalebc@gmail.com>
jamshale
commented
Jul 29, 2024
Signed-off-by: jamshale <jamiehalebc@gmail.com>
|
darshilnb
pushed a commit
to Northern-Block/aries-cloudagent-python
that referenced
this pull request
Sep 5, 2024
* Add rekey feature with blank key support Signed-off-by: jamshale <jamiehalebc@gmail.com> * Refactor / Remove other key exists check / unit tests Signed-off-by: jamshale <jamiehalebc@gmail.com> * Remove no wallet key test from store config Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com> Co-authored-by: Ian Costanzo <ian@anon-solutions.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2999.
This adds the support to change wallet keys and also allows any wallets created with a blank key before it was required in 0.12.0 to change their key and unblock the upgrade.
This allow an agent stuck in a state where they used a blank key to configure a wallet-key that won't be used, but will be replaced by the
rekeyvariable. After using rekey they can then use that key in the wallet-key config.