-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TxnOrPublishRevocationsResultSchema
#3164
Conversation
Signed-off-by: cl0ete <cloete.dupreez@gmail.com>
Signed-off-by: cl0ete <cloete.dupreez@gmail.com>
Signed-off-by: cl0ete <cloete.dupreez@gmail.com>
Signed-off-by: cl0ete <cloete.dupreez@gmail.com>
Signed-off-by: cl0ete <cloete.dupreez@gmail.com>
Signed-off-by: cl0ete <cloete.dupreez@gmail.com>
Signed-off-by: cl0ete <cloete.dupreez@gmail.com>
Signed-off-by: cl0ete <cloete.dupreez@gmail.com>
Signed-off-by: cl0ete <cloete.dupreez@gmail.com>
Signed-off-by: cl0ete <cloete.dupreez@gmail.com>
Tested that the OpenAPI and SwaggerAPI files match the generated. I don’t know enough about the functionality to determine if it is right — adding reviewers. For reviewers — is this OK to go into 1.0.0 or should we hold it until that is complete? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good.
@swcurran This should be safe to include in 1.0.0. I didn't think it was important enough to need to get in, but we could include it if it doesn't hold anything up. edit: If we wanted to change it later it would have to be considered a breaking change ( Although minor ). So might as well get it in. |
Quality Gate passedIssues Measures |
* fix response for publish revocations Signed-off-by: cl0ete <cloete.dupreez@gmail.com> * add logging Signed-off-by: cl0ete <cloete.dupreez@gmail.com> * update model to make txn a list of TransactionRecordSchema Signed-off-by: cl0ete <cloete.dupreez@gmail.com> * update return value to match response model Signed-off-by: cl0ete <cloete.dupreez@gmail.com> * remove logging Signed-off-by: cl0ete <cloete.dupreez@gmail.com> * ran script generate-open-api-spec Signed-off-by: cl0ete <cloete.dupreez@gmail.com> * remove white space Signed-off-by: cl0ete <cloete.dupreez@gmail.com> * TxnOrPublishRevocations... extends PublishRevocationsSchema Signed-off-by: cl0ete <cloete.dupreez@gmail.com> * remove sent i.e. revert back Signed-off-by: cl0ete <cloete.dupreez@gmail.com> * ran script generate-open-api-spec Signed-off-by: cl0ete <cloete.dupreez@gmail.com> --------- Signed-off-by: cl0ete <cloete.dupreez@gmail.com>
Update
TxnOrPublishRevocationsResultSchema
to accommodate changes made in PR #3107Tweak return values from
publish_revocations
to match response model.Ran the script
generate-open-api-spec
to updateopenapi.json
andswagger.json
files