fix(react-hooks): update react peer dependency #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
TimoGlastra
requested changes
Aug 26, 2022
| @@ -29,12 +29,12 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@aries-framework/core": "^0.2.0", | |||
| "react": "^17.0.2", | |||
| "react": "^18.0.0", | |||
There was a problem hiding this comment.
What if we make it a semver range
E.g.:
>=17.0.0 <=19.0.0
or just
>=17.0.0
Then it doesn't have to be a breaking change
There was a problem hiding this comment.
I don't see any reason that would not work! You are a wise man Timo, this hadn't occurred to me 👏 I'll go ahead and update this shortly.
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
TimoGlastra
changed the title
TimoGlastra
changed the title
|
Marking it as fix as chore won't trigger a new release (and we're technically fixing an issue here :) |
TimoGlastra
approved these changes
Aug 30, 2022
|
Ahh thanks for catching the 'chore' vs 'fix' issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the React peer dependency to 18.0.0 as part of an effort to update Aries Bifold to newer versions of React Native.
This would be considered a breaking change according to Semver due to the peer dependency change (via semver/semver#502)