Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-hooks): update react peer dependency #151

Merged
merged 2 commits into from
Aug 30, 2022
Merged

fix(react-hooks): update react peer dependency #151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3362f64
chore: update react peer dependency
JamesKEbert Aug 25, 2022
8a6bfeb
chore: updated peer dependency to be a range for react
JamesKEbert Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-hooks/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@
},
"devDependencies": {
"@aries-framework/core": "^0.2.0",
"react": "^17.0.2",
"react": "^18.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we make it a semver range

E.g.:

>=17.0.0 <=19.0.0

or just

>=17.0.0

Then it doesn't have to be a breaking change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason that would not work! You are a wise man Timo, this hadn't occurred to me 👏 I'll go ahead and update this shortly.

"rimraf": "~3.0.2",
"typescript": "~4.4.2"
},
"peerDependencies": {
"@aries-framework/core": "^0.2.0",
"react": "^17.0.2"
"react": ">=17.0.0 <19.0.0"
}
}