Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose reverting issue-credential-v2 and present-proof-v2 to v2.0, removing v2.1 and v2.2 #815

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Propose reverting issue-credential-v2 and present-proof-v2 to v2.0, removing v2.1 and v2.2 #815

merged 3 commits into from
Mar 13, 2024

Conversation

swcurran
Copy link
Member

Proposes that we remove v2.1 and v2.2 from these two protocols, as they are not implemented, v2.1 is not easily implemented (and is an edge case), and makes upgrading to V3.0 harder for anyone that does actually implement them. The bottom line is that as far as we know, no one has implemented these versions, and we want it to stay that way.

To make this change, I copy/pasted the RFCs from those defined in AIP 2.0, and then put in any clarifications that were unrelated to the v2.1 and v2.2 changes. The result is (I think) an up to date version of each RFC that reflects the reality and direction of the community.

To be discussed at an upcoming Aries Working Group meeting.

…emoving v2.1 and v2.2

Signed-off-by: Stephen Curran <swcurran@gmail.com>
Copy link
Member

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at the PR content ls, but I agree with making v2.0 the AIP target and reverting the additions

Copy link
Contributor

@TelegramSam TelegramSam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed WG 20240313.

@TelegramSam
Copy link
Contributor

WG agreed to merging

Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran swcurran merged commit e8a23a7 into hyperledger:main Mar 13, 2024
1 check passed
@swcurran swcurran deleted the remove-v2.2-cred-exchange branch March 13, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants