Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status STALLED and change status of many proposed RFCs #827

Merged
merged 6 commits into from
May 2, 2024

Conversation

swcurran
Copy link
Member

@swcurran swcurran commented Apr 1, 2024

We have many RFCs that are in the "Proposed" status that are very unlikely to be progressed any further. To clear them out so that people have a better view of the active work in Aries, a new status "STALLED" has been added, and the status of many proposed RFCs have been changed to either STALLED, DEMONSTRATED or ACCEPTED, as appropriate based on the work done on the RFCs.

STALLED differs from the RETIRED state in that STALLED is direct from PROPOSED, whereas RETIRED is from a more advanced state, where implementation work was done, evaluated and found to be no longer of use. STALLED just means that the idea never got beyond the idea stage.

Updated statuses:

  • STALLED: concepts/0029-message-trust-contexts/README.md
  • RETIRED: concepts/0051-dkms/README.md
  • STALLED: concepts/0207-credential-fraud-threat-model/README.md
  • STALLED: concepts/0217-linkable-message-paths/README.md
  • STALLED: concepts/0250-rich-schemas/README.md
  • STALLED: concepts/0257-private-credential-issuance/README.md
  • STALLED: concepts/0268-unified-didcomm-agent-deeplinking/README.md
  • STALLED: concepts/0289-toip-stack/README.md
  • STALLED: concepts/0420-rich-schemas-common/README.md
  • STALLED: concepts/0478-coprotocols/README.md
  • STALLED: concepts/0700-oob-through-redirect/README.md
  • STALLED: features/0024-didcomm-over-xmpp/README.md
  • STALLED: features/0030-sync-connection/README.md
  • STALLED: features/0075-payment-decorators/README.md
  • STALLED: features/0114-predefined-identities/README.md
  • STALLED: features/0116-evidence-exchange/README.md
  • STALLED: features/0193-coin-flip/README.md
  • STALLED: features/0213-transfer-policy/README.md
  • STALLED: features/0214-help-me-discover/README.md
  • STALLED: features/0249-rich-schema-contexts/README.md
  • STALLED: features/0281-rich-schemas/README.md
  • STALLED: features/0309-didauthz/README.md
  • STALLED: features/0327-crypto-service/README.md
  • STALLED: features/0334-jwe-envelope/README.md
  • STALLED: features/0335-http-over-didcomm/README.md
  • STALLED: features/0347-proof-negotiation/README.md
  • STALLED: features/0351-purpose-decorator/README.md
  • STALLED: features/0418-rich-schema-encoding/README.md
  • STALLED: features/0428-prepare-issue-rich-credential/README.md
  • STALLED: features/0429-prepare-req-rich-pres/README.md
  • STALLED: features/0445-rich-schema-mapping/README.md
  • STALLED: features/0446-rich-schema-cred-def/README.md
  • STALLED: features/0482-coprotocol-protocol/README.md
  • STALLED: features/0641-linking-binary-objects-to-credentials/README.md
  • STALLED: features/0693-credential-representation/README.md
  • DEMONSTRATED: features/0755-oca-for-aries/README.md
  • DEMONSTRATED: features/0756-oca-for-aries-style-guide/README.md
  • DEMONSTRATED: features/0780-data-urls-images/README.md
  • ACCEPTED: features/0794-did-rotate/README.md
  • DEMONSTRATED: features/0804-didcomm-rpc/README.md
  • DEMONSTRATED: features/0809-w3c-data-integrity-credential-attachment/README.md

Signed-off-by: Stephen Curran <swcurran@gmail.com>
Copy link
Member

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@JamesKEbert
Copy link
Contributor

I'm highly in favor of adding a stalled status. 👍

Here's some additional RFCs I'd propose for status changes:
ACCEPTED: features/0183-revocation-notification/README.md (it's included in AIPv2, so it should probably move to accepted--even though revocation notification v2 would be preferable for implementation)
ACCEPTED: features/0721-revocation-notification-v2/README.md
ACCEPTED: features/0685-pickup-v2/README.md
ADOPTED: features/0015-acks/README.md
ADOPTED: concepts/0017-attachments/README.md
ADOPTED: features/0035-report-problem/README.md
ADOPTED: features/0092-transport-return-route/README.md
ADOPTED: concepts/0094-cross-domain-messaging/README.md
ADOPTED: features/0211-route-coordination/README.md
ADOPTED: features/0360-use-did-key/README.md
ADOPTED: concepts/0441-present-proof-best-practices/README.md
ADOPTED: features/0557-discover-features-v2/README.md

Signed-off-by: Stephen Curran <swcurran@gmail.com>
Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran
Copy link
Member Author

swcurran commented May 1, 2024

At the Aries Working Group meeting 2024-05-01, we went through a list of all of the proposed changes in this PR, as listed in this spreadsheet.

There was agreement and no objections to the following actions:

  • For the RFCs marked "review" in the spreadsheet, revert the change to "STALLED", pending a further review. A new PR will be created should a change in status in those RFCs is called for. The review list is:
    • 0268-unified-didcomm-agent-deeplinking
    • 0700-oob-through-redirect
    • 0213-transfer-policy
    • 0214-help-me-discover
    • 0347-proof-negotiation
    • 0641-linking-binary-objects-to-credentials
    • 0693-credential-representation
  • For the RFCs proposed for status changes by @JamesKEbert in this comment, we agreed to apply all of those changes.
  • Once those updates to this PR have been made -- merge this PR.

As of the writing of this comment, all of those changes have been made.

@JamesKEbert -- could I get you to review the changes to make sure I didn't make a mistake in applying the spreadsheet changes? Or anyone else. The PR is approved so in theory COULD be applied, but I'd appreciate another pair of eyes on it.

Thanks!

@swcurran swcurran requested a review from JamesKEbert May 1, 2024 18:20
Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of minor catches. 👍

index.md Outdated Show resolved Hide resolved
index.md Outdated Show resolved Hide resolved
index.md Outdated
Comment on lines 104 to 105
* [0213: Transfer Policy Protocol](features/0213-transfer-policy/README.md) (2024-04-03 &mdash; [`feature`](/tags.md#feature) [`protocol`](/tags.md#protocol))
* [0214: "Help Me Discover" Protocol](features/0214-help-me-discover/README.md) (2024-04-03 &mdash; [`feature`](/tags.md#feature) [`protocol`](/tags.md#protocol))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked for review, should stay in proposed

index.md Outdated Show resolved Hide resolved
index.md Outdated Show resolved Hide resolved
index.md Outdated Show resolved Hide resolved
index.md Show resolved Hide resolved
mkdocs.yml Show resolved Hide resolved
Comment on lines 1 to 8
# 0213: Transfer Policy Protocol
- Authors: [Sam Curren](telegramsam@gmail.com)
- Status: [PROPOSED](/README.md#proposed)
- Since: 2019-09-03
- Status Note: Initial version
- Status: [STALLED](/README.md#stalled)
- Since: 2024-04-03
- Status Note: No implementations have been created.
- Start Date: 2019-09-03
- Tags: [feature](/tags.md#feature), [protocol](/tags.md#protocol)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked for review, should stay proposed.

Signed-off-by: Stephen Curran <swcurran@gmail.com>
Signed-off-by: Stephen Curran <swcurran@gmail.com>
Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran
Copy link
Member Author

swcurran commented May 2, 2024

Sorry about that @JamesKEbert — I ran the site generator script thinking that would be update the index as well. So, changed the script so now it does that, and included the updated index.md in this PR. The index.md will can/will be removed once the published site is the “go to” location, as the site is maintained by GitHub Actions, while the index.md requires a PR (like this one!).

Also fixed 213 that I missed.

Fixed - please confirm and let’s get this puppy merged! :-)

Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get it merged!

@swcurran swcurran merged commit 393c46a into hyperledger:main May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants