Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds net-restrict to cli options #1646

Merged
merged 9 commits into from
Jul 23, 2024

Conversation

m4sterbunny
Copy link
Contributor

Description

Adds net-restrict to CLI options (supports Comma-separated array of allowed IP subnets).

Issue(s) fixed

Fixes #1625

Preview

Signed-off-by: m4sterbunny <harrie.bickle@consensys.net>
@m4sterbunny m4sterbunny requested a review from a team as a code owner July 4, 2024 12:15
Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 2:19pm

@macfarla macfarla changed the title adds nat-restrict to cli options adds net-restrict to cli options Jul 9, 2024
m4sterbunny and others added 2 commits July 9, 2024 07:36
as per Besu's array == 1 required, array accepted

Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
Signed-off-by: m4sterbunny <harrie.bickle@consensys.net>
if this, then need to do run through pg and verify previous

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: m4sterbunny <harrie.bickle@consensys.net>
@m4sterbunny
Copy link
Contributor Author

Signed-off-by: m4sterbunny <harrie.bickle@consensys.net>
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once suggestions are addressed. This could still use a technical approval.

docs/public-networks/how-to/connect/manage-peers.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/connect/manage-peers.md Outdated Show resolved Hide resolved
docs/public-networks/reference/cli/options.md Outdated Show resolved Hide resolved
m4sterbunny and others added 4 commits July 22, 2024 15:03
proof

Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
Signed-off-by: m4sterbunny <harrie.bickle@consensys.net>
proof

Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
Signed-off-by: m4sterbunny <harrie.bickle@consensys.net>
proof

Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
Signed-off-by: m4sterbunny <harrie.bickle@consensys.net>
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m4sterbunny m4sterbunny merged commit 4087322 into hyperledger:main Jul 23, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document subnet-based peer permissions
5 participants