Correctly release txpool save and restore lock in case of exceptions

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
hyperledger · Aug 16, 2024 · 4cbb5ff · 4cbb5ff
1 parent 8523ed0
commit 4cbb5ff
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/...eum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPool.java b/...eum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPool.java
@@ -706,7 +706,8 @@ private CompletableFuture<Void> serializeAndDedupOperation(
 
             isCancelled.set(false);
             operationInProgress.set(
-                CompletableFuture.runAsync(operation).thenRun(diskAccessLock::release));
+                CompletableFuture.runAsync(operation)
+                    .whenComplete((res, err) -> diskAccessLock.release()));
             return operationInProgress.get();
           } else {
             CompletableFuture.failedFuture(