Update unit tests

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
hyperledger · Jun 25, 2024 · 6275204 · 6275204
1 parent f0606ef
commit 6275204
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/...ger/besu/tests/acceptance/permissioning/NodeSmartContractPermissioningAcceptanceTest.java b/...ger/besu/tests/acceptance/permissioning/NodeSmartContractPermissioningAcceptanceTest.java
@@ -37,17 +37,20 @@ public void setUp() {
     permissionedCluster.start(bootnode, forbiddenNode, allowedNode, permissionedNode);
 
     // updating permissioning smart contract with allowed nodes
-
+    permissionedNode.verify(nodeIsForbidden(bootnode));
     permissionedNode.execute(allowNode(bootnode));
     permissionedNode.verify(nodeIsAllowed(bootnode));
 
+    // No need to add peer as Besu treats bootnodes as maintained nodes
+    // just like static nodes. Just check that it has been added
+    permissionedNode.verify(admin.hasPeer(bootnode));
+
     permissionedNode.execute(allowNode(allowedNode));
     permissionedNode.verify(nodeIsAllowed(allowedNode));
 
     permissionedNode.execute(allowNode(permissionedNode));
     permissionedNode.verify(nodeIsAllowed(permissionedNode));
 
-    permissionedNode.verify(admin.addPeer(bootnode));
     permissionedNode.verify(admin.addPeer(allowedNode));
 
     allowedNode.verify(eth.syncingStatus(false));

diff --git a/besu/src/main/java/org/hyperledger/besu/RunnerBuilder.java b/besu/src/main/java/org/hyperledger/besu/RunnerBuilder.java
@@ -790,7 +790,8 @@ public Runner build() {
       LOG.debug("added ethash observer: {}", stratumServer.get());
     }
 
-    // Make sure Besu maintains connections to static nodes and bootnodes, including retries periodically
+    // Make sure Besu maintains connections to static nodes and bootnodes, including retries
+    // periodically
     Stream.concat(sanitizePeers(network, staticNodes), sanitizePeers(network, bootnodes))
         .map(DefaultPeer::fromEnodeURL)
         .forEach(peerNetwork::addMaintainedConnectionPeer);