Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate CLI option for privacy precompile address #1222

Merged
merged 4 commits into from
Jul 15, 2020

Conversation

macfarla
Copy link
Contributor

Deprecate the CLI option and log a warning if used. Derive the address instead based on whether onchain privacy groups option is enabled.

PR description

Fixed Issue(s)

See #469

macfarla added 4 commits July 15, 2020 11:49
…evant precompile in the registry

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Copy link
Member

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucassaldanha lucassaldanha merged commit 13886d2 into hyperledger:master Jul 15, 2020
@macfarla macfarla deleted the 469-precompile-deprecate branch July 15, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants