Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Docker Images with different JVMs #1277

Merged
merged 8 commits into from
Aug 6, 2020

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Aug 5, 2020

Create different Docker images with different base JVMs. Initially
OpenJDK 11.0.7, whatever OpenJDK latest is (14.0.1 at the moment), and
Graal 20.1.0 .

We still maintain a "Default" which will remain Java 11.0.x

Signed-off-by: Danno Ferrin danno.ferrin@gmail.com

shemnon added 4 commits August 5, 2020 16:21
Create different Docker images with different base JVMs.  Initially
OpenJDK 11.0.7, whatever OpenJDK latest is (14.0.1 at the moment), and
Graal 20.1.0 .

We still maintain a "Default" which will remain Java 11.0.x

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
@shemnon shemnon marked this pull request as ready for review August 6, 2020 00:05
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>

FROM oracle/graalvm-ce:20.1.0-java11

RUN adduser --home /opt/besu besu && \
Copy link
Contributor Author

@shemnon shemnon Aug 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oracle linux is different, am I losing security by not finding the replacement for --disabled-password --gecos "" ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are required on the other image to avoid having it prompt for the password and user information (like Full Name, Room Number etc). Oracle Linux doesn't do those prompts so won't need the extra options.

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -0,0 +1,41 @@

FROM openjdk:11.0.7-jre-slim-buster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this replace the existing docker/Dockerfile which still seems to be present?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. It was sitting in another CL.


FROM oracle/graalvm-ce:20.1.0-java11

RUN adduser --home /opt/besu besu && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are required on the other image to avoid having it prompt for the password and user information (like Full Name, Room Number etc). Oracle Linux doesn't do those prompts so won't need the extra options.

shemnon added 3 commits August 5, 2020 20:42
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
@shemnon shemnon merged commit 8067ff4 into hyperledger:master Aug 6, 2020
@shemnon shemnon deleted the multiDocker branch February 26, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants