-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Docker Images with different JVMs #1277
Conversation
Create different Docker images with different base JVMs. Initially OpenJDK 11.0.7, whatever OpenJDK latest is (14.0.1 at the moment), and Graal 20.1.0 . We still maintain a "Default" which will remain Java 11.0.x Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
|
||
FROM oracle/graalvm-ce:20.1.0-java11 | ||
|
||
RUN adduser --home /opt/besu besu && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oracle linux is different, am I losing security by not finding the replacement for --disabled-password --gecos ""
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are required on the other image to avoid having it prompt for the password and user information (like Full Name, Room Number etc). Oracle Linux doesn't do those prompts so won't need the extra options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
docker/openjdk-11/Dockerfile
Outdated
@@ -0,0 +1,41 @@ | |||
|
|||
FROM openjdk:11.0.7-jre-slim-buster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this replace the existing docker/Dockerfile which still seems to be present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. It was sitting in another CL.
|
||
FROM oracle/graalvm-ce:20.1.0-java11 | ||
|
||
RUN adduser --home /opt/besu besu && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are required on the other image to avoid having it prompt for the password and user information (like Full Name, Room Number etc). Oracle Linux doesn't do those prompts so won't need the extra options.
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Create different Docker images with different base JVMs. Initially
OpenJDK 11.0.7, whatever OpenJDK latest is (14.0.1 at the moment), and
Graal 20.1.0 .
We still maintain a "Default" which will remain Java 11.0.x
Signed-off-by: Danno Ferrin danno.ferrin@gmail.com