-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Image for EVMTool #1313
Merged
Merged
Docker Image for EVMTool #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move key referenceTest classes relating to reading the JSON data into a "main" java package so that it can be included in other production classes. Some classes were renamed to make their intent clearer. Other smaller changes that bring classes in line with curerrent coding standards were done. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Add the state-test subcommand to evmTool, to support fuzz testing initiatives. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
* allow reference tests to use the standard input * pay attention to the `--json` flag for by-op tracing (still print summary) Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Create a docker image for EVMTool, so that the GoEvmLab tool can easily integrate the besu EVM into it's fuzzing framework. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Overall this looks good to me but allowing someone with more Docker expertise to review and approve. |
…est3 Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
joshuafernandes
approved these changes
Aug 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Create a docker image for EVMTool, so that the GoEvmLab tool can easily
integrate the besu EVM into its fuzzing framework.
Signed-off-by: Danno Ferrin danno.ferrin@gmail.com
requires #1311
Changelog