added genesis config option ecip1017EraRounds for Ethereum Classic chains #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to define the number of Rounds in an Era for Ethereum Classic Emission Schedule. Signed-off-by: Edward Mack <ed@edwardmack.com>
Signed-off-by: Edward Mack <ed@edwardmack.com>
shemnon
reviewed
Aug 25, 2020
config/src/main/java/org/hyperledger/besu/config/GenesisConfigOptions.java
Outdated
Show resolved
Hide resolved
shemnon
approved these changes
Aug 25, 2020
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/ClassicBlockProcessor.java
Outdated
Show resolved
Hide resolved
shemnon
reviewed
Aug 25, 2020
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/ClassicBlockProcessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Edward Mack <ed@edwardmack.com>
…/besu into ed/mordor_era_handling
|
Thanks for squeezing this in, guys. Just spotted this typo while looking at the diffs - DEFALUT_ERA_LENGTH Best wishes! |
|
@bobsummerwill thanks for catching the typo, fixed in PR #1343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Ethereum Classic ECIP-1017 Monetary Policy and Final Modification to the Ethereum Classic Emission Schedule introduces the concept of an "Era" which is defined as the number of blocks containing a given production rate. The Ethereum Classic Network uses a value of 5,000,000 blocks for an Era.
This PR introduces a genesis config option named
ecip1017EraRoundsto define the number of Rounds in an Era. This config value is used in the mordor.json config since the Mordor testnet uses a 2,000,000 block Era.If
ecip1017EraRoundsis not configured, the node will default to 5,000,000 blocks per Era.Signed-off-by: Edward Mack ed@edwardmack.com
Fixed Issue(s)
Fixes issue where node would not sync past 2,000,000 blocks on Mordor testnet.
Changelog