[issue-1300] Update net_version JSON-RPC call to return network ID instead of chain ID #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Mack <ed@edwardmack.com>
Signed-off-by: Edward Mack <ed@edwardmack.com>
shemnon
reviewed
Sep 1, 2020
There was a problem hiding this comment.
Tests?
org.hyperledger.besu.ethereum.api.jsonrpc.internal.methods.NetVersionTestwill need at least editorial changes- There should be an integration test somehow where chainId and networkId differ. I think adding two tests in
ethereum/api/src/test/resources/org/hyperledger/besu/ethereum/api/jsonrpc/eth, one for theeth_chainIdmethod and one fornet_versionshould prove it because I think networkId is 123 and chainId is 1 in those tests.
...m/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/methods/NetJsonRpcMethods.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Edward Mack <ed@edwardmack.com>
|
@shemnon I've added testing, I believe we have good coverage now. Let me know your thoughts. |
shemnon
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR implements fix to JSON-RPC method
net_versionto return network ID as specified in https://eth.wiki/json-rpc/API#net_version.Signed-off-by: Edward Mack ed@edwardmack.com
Fixed Issue(s)
fixes #1300
Changelog