Add debug_getBadBlocks method #1378

matkt · 2020-09-11T15:43:31Z

Signed-off-by: Karim TAAM karim.t2am@gmail.com

PR description

Request

{"jsonrpc":"2.0","method":"debug_getBadBlocks","params":[],"id":1}

Response

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": [
        {
            "block": {
                "number": "0xd",
                "hash": "0x85c2edc1ca74b4863cab46ff6ed4df514a698aa7c29a9bce58742a33af07d7e6",
                "mixHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
                "parentHash": "0x544a2f7a4c8defc0d8da44aa0c0db7c36b56db2605c01ed266e919e936579d31",
                "nonce": "0x0000000000000000",
                "sha3Uncles": "0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347",
                "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
                "transactionsRoot": "0x02c387e001cbe2a8296bfa2e18afbc3480d0e49588b05556148b0bf7c17dec41",
                "stateRoot": "0x861ab7e868e3c23f84b7c4ed86b52a6a4f063633bc45ef29212c33459df84ea5",
                "receiptsRoot": "0xccd2d33763dc0ac3fe02d4ecbbcd7d2bdc6f57db635ba31007184679303721d7",
                "miner": "0x0000000000000000000000000000000000000000",
                "difficulty": "0x1",
                "totalDifficulty": "0x1",
                "extraData": "0x00000000000000000000000000000000000000000000000000000000000000008c6a091f07e4ba3930f2f5fabbfc5b1c70986319096760ba200a6abc0d30e33c2d501702d1b58d7f75807bdbf981044557628611319121170b96466ec06bb3fd01",
                "size": "0x3a0",
                "gasLimit": "0xffffffffffff",
                "gasUsed": "0x1a488",
                "timestamp": "0x5f5b6824",
                "uncles": [],
                "transactions": [
                    {
                        "blockHash": "0x85c2edc1ca74b4863cab46ff6ed4df514a698aa7c29a9bce58742a33af07d7e6",
                        "blockNumber": "0xd",
                        "from": "0xfe3b557e8fb62b89f4916b721be55ceb828dbd73",
                        "gas": "0x1a49e",
                        "gasPrice": "0x3e8",
                        "hash": "0xdd8cf045113754c306ba9ac8ac8786235e33bc5c087678084ef260a2a583f127",
                        "input": "0x608060405234801561001057600080fd5b5060c78061001f6000396000f3fe6080604052348015600f57600080fd5b506004361060325760003560e01c80636057361d146037578063b05784b8146062575b600080fd5b606060048036036020811015604b57600080fd5b8101908080359060200190929190505050607e565b005b60686088565b6040518082815260200191505060405180910390f35b8060008190555050565b6000805490509056fea26469706673582212208dea039245bf78c381278382d7056eef5083f7d243d8958817ef447e0a403bd064736f6c63430006060033",
                        "nonce": "0x0",
                        "to": null,
                        "transactionIndex": "0x0",
                        "value": "0x0",
                        "v": "0xf9d",
                        "r": "0xa7a15050302ca4b7d3842d35cdd3cbf25b2c48c0c37f96d78beb6a6a6bc4f1c7",
                        "s": "0x130d29294b2b6a2b7e89f501eb27772f7abf37bfa28a1ce300daade975589fca"
                    }
                ]
            },
            "hash": "0x85c2edc1ca74b4863cab46ff6ed4df514a698aa7c29a9bce58742a33af07d7e6",
            "rlp": "0xf9039df9025ca0544a2f7a4c8defc0d8da44aa0c0db7c36b56db2605c01ed266e919e936579d31a01dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347940000000000000000000000000000000000000000a0861ab7e868e3c23f84b7c4ed86b52a6a4f063633bc45ef29212c33459df84ea5a002c387e001cbe2a8296bfa2e18afbc3480d0e49588b05556148b0bf7c17dec41a0ccd2d33763dc0ac3fe02d4ecbbcd7d2bdc6f57db635ba31007184679303721d7b9010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010d86ffffffffffff8301a488845f5b6824b86100000000000000000000000000000000000000000000000000000000000000008c6a091f07e4ba3930f2f5fabbfc5b1c70986319096760ba200a6abc0d30e33c2d501702d1b58d7f75807bdbf981044557628611319121170b96466ec06bb3fd01a00000000000000000000000000000000000000000000000000000000000000000880000000000000000f9013af90137808203e88301a49e8080b8e6608060405234801561001057600080fd5b5060c78061001f6000396000f3fe6080604052348015600f57600080fd5b506004361060325760003560e01c80636057361d146037578063b05784b8146062575b600080fd5b606060048036036020811015604b57600080fd5b8101908080359060200190929190505050607e565b005b60686088565b6040518082815260200191505060405180910390f35b8060008190555050565b6000805490509056fea26469706673582212208dea039245bf78c381278382d7056eef5083f7d243d8958817ef447e0a403bd064736f6c63430006060033820f9da0a7a15050302ca4b7d3842d35cdd3cbf25b2c48c0c37f96d78beb6a6a6bc4f1c7a0130d29294b2b6a2b7e89f501eb27772f7abf37bfa28a1ce300daade975589fcac0"
        },
        {
            "block": {
                "number": "0x8",
                "hash": "0x601a3ae9b6eceb2476d249e1cffe058ba3ff2c9c1b28b1ec7a0259fdd1d90121",
                "mixHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
                "parentHash": "0x98ae440cd7b904d842daa6c263608969a3c8ce6a9acd6bd1f99b394f5f28a207",
                "nonce": "0x0000000000000000",
                "sha3Uncles": "0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347",
                "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
                "transactionsRoot": "0x8ee998cc699a1f9310a1079458780b3ebee8756f96a0905f5224b89d0eb17486",
                "stateRoot": "0x140a9783291704223eb759e3a0db5471a520d349fc17ac2f77ff8582472e3bac",
                "receiptsRoot": "0x2b5c77f6e7764d2468178fab7253346b9b8bb6a34b63946f6bdc2f5ad398bfc3",
                "miner": "0x0000000000000000000000000000000000000000",
                "difficulty": "0x2",
                "totalDifficulty": "0x2",
                "extraData": "0x00000000000000000000000000000000000000000000000000000000000000004d04551bdd9ae08af1fd661e49d4ab662c98c532c7ec0e4656a27e4de7d330af578ab1e4f5e49e085ff1d78673c7388ed9ccf017fbe89e53066bfa4018142c0701",
                "size": "0x3a0",
                "gasLimit": "0xffffffffffff",
                "gasUsed": "0x1a4c9",
                "timestamp": "0x5f5b6b80",
                "uncles": [],
                "transactions": [
                    {
                        "blockHash": "0x601a3ae9b6eceb2476d249e1cffe058ba3ff2c9c1b28b1ec7a0259fdd1d90121",
                        "blockNumber": "0x8",
                        "from": "0xfe3b557e8fb62b89f4916b721be55ceb828dbd73",
                        "gas": "0x1a4c9",
                        "gasPrice": "0x3e8",
                        "hash": "0x675e336a4281b29c619dfd4ccfbd2f930f3728b20caf9e0067284aa3224e6758",
                        "input": "0x608060405234801561001057600080fd5b5060c78061001f6000396000f3fe6080604052348015600f57600080fd5b506004361060325760003560e01c80636057361d146037578063b05784b8146062575b600080fd5b606060048036036020811015604b57600080fd5b8101908080359060200190929190505050607e565b005b60686088565b6040518082815260200191505060405180910390f35b8060008190555050565b6000805490509056fea26469706673582212208dea039245bf78c381278382d7056eef5083f7d243d8958817ef447e0a403bd064736f6c63430006060033",
                        "nonce": "0x0",
                        "to": null,
                        "transactionIndex": "0x0",
                        "value": "0x0",
                        "v": "0xf9d",
                        "r": "0x2e30624c0305e64812e1d9e325ba6e50410314634b008edcb50f45be71fa0d4",
                        "s": "0x50e205faed23c219ba15610de2451d458cbd4221207b2168344cfc972a7973c0"
                    }
                ]
            },
            "hash": "0x601a3ae9b6eceb2476d249e1cffe058ba3ff2c9c1b28b1ec7a0259fdd1d90121",
            "rlp": "0xf9039df9025ca098ae440cd7b904d842daa6c263608969a3c8ce6a9acd6bd1f99b394f5f28a207a01dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347940000000000000000000000000000000000000000a0140a9783291704223eb759e3a0db5471a520d349fc17ac2f77ff8582472e3baca08ee998cc699a1f9310a1079458780b3ebee8756f96a0905f5224b89d0eb17486a02b5c77f6e7764d2468178fab7253346b9b8bb6a34b63946f6bdc2f5ad398bfc3b9010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000020886ffffffffffff8301a4c9845f5b6b80b86100000000000000000000000000000000000000000000000000000000000000004d04551bdd9ae08af1fd661e49d4ab662c98c532c7ec0e4656a27e4de7d330af578ab1e4f5e49e085ff1d78673c7388ed9ccf017fbe89e53066bfa4018142c0701a00000000000000000000000000000000000000000000000000000000000000000880000000000000000f9013af90137808203e88301a4c98080b8e6608060405234801561001057600080fd5b5060c78061001f6000396000f3fe6080604052348015600f57600080fd5b506004361060325760003560e01c80636057361d146037578063b05784b8146062575b600080fd5b606060048036036020811015604b57600080fd5b8101908080359060200190929190505050607e565b005b60686088565b6040518082815260200191505060405180910390f35b8060008190555050565b6000805490509056fea26469706673582212208dea039245bf78c381278382d7056eef5083f7d243d8958817ef447e0a403bd064736f6c63430006060033820f9da002e30624c0305e64812e1d9e325ba6e50410314634b008edcb50f45be71fa0d4a050e205faed23c219ba15610de2451d458cbd4221207b2168344cfc972a7973c0c0"
        }
    ]
}

Test Performed on a local testnet :

FULL sync with a consensus issue
FAST sync with a consensus issue
Peer send a new block with a consensus issue
Reorg with a second consensus issue
Invalid header or body, evm errors

Changelog

I thought about the changelog and included a changelog update if required.

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

…' into feature/add-debug-get-bad-blocks

…' into feature/add-debug-get-bad-blocks Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

shemnon · 2020-09-16T19:14:36Z

.../main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/DebugGetBadBlocks.java

+    final List<BadBlockResult> response = new ArrayList<>();
+    final BadBlockManager badBlockManager =
+        protocolSchedule.getByBlockNumber(blockchain.headBlockNumber()).getBadBlocksManager();
+    badBlockManager


Maybe .stream().map(...).collect(Collectors.toList) instead of adding to a mutable collection?

shemnon · 2020-09-16T19:15:17Z

...src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/BadBlockResult.java

+import org.apache.tuweni.bytes.Bytes;
+
+@JsonPropertyOrder({"block", "hash", "rlp"})
+public class BadBlockResult {


What was your take on the Immutable Framework? Did you like it/not like it? This is another opportunity here.

yes I find it very useful. just forgot to use it :) updated

shemnon · 2020-09-16T19:21:57Z

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/BadBlockManager.java

+
+public class BadBlockManager {
+
+  private final Map<Hash, Block> badBlocks = new ConcurrentHashMap<>();


We want some sort of a limit on the bad blocks we keep around. Maybe via com.google.common.cache.CacheBuilder?

Geth said they keep on the order of 100 in memory.

Indeed I wanted to use the cacheBuilder but as I understood that we did not want a limit for this cache I did not set it up. But anyway the choice to put a limit is much better

shemnon · 2020-09-16T19:24:20Z

...h/src/main/java/org/hyperledger/besu/ethereum/eth/sync/tasks/DownloadHeaderSequenceTask.java

-                  new InvalidBlockException(
-                      "Header failed validation.", child.getNumber(), child.getHash()));
+
+              final BlockHeader invalidBlock = child;


Add some comments explaining that even though the header is known bad we are downloading the block body for the debug_badBlocks RPC.

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

matkt added 5 commits September 11, 2020 17:32

init getBadBlocks endpoint

74f9bf3

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

Merge branch 'master' into feature/add-debug-get-bad-blocks

1f1f141

add missing files

34e139c

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

Merge remote-tracking branch 'origin/feature/add-debug-get-bad-blocks…

15ead17

…' into feature/add-debug-get-bad-blocks

Merge remote-tracking branch 'origin/feature/add-debug-get-bad-blocks…

2f8e7a8

…' into feature/add-debug-get-bad-blocks Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

matkt force-pushed the feature/add-debug-get-bad-blocks branch from 15ead17 to 2f8e7a8 Compare September 11, 2020 16:31

MadelineMurray mentioned this pull request Sep 14, 2020

Doc debug_getBadBlocks hyperledger/besu-docs#513

Closed

matkt added 3 commits September 14, 2020 11:06

fix javadoc

b352d66

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

fix pipeline

77d7e92

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

update CHANGELOG.md

0e03d86

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

matkt marked this pull request as ready for review September 14, 2020 11:44

shemnon self-requested a review September 16, 2020 17:36

shemnon approved these changes Sep 16, 2020

View reviewed changes

matkt added 2 commits September 16, 2020 23:00

fix review issues

936ad0b

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

Merge commit 'master' into feature/add-debug-get-bad-blocks

7faa1f4

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

matkt merged commit be89cd9 into hyperledger:master Sep 17, 2020

matkt deleted the feature/add-debug-get-bad-blocks branch September 29, 2020 11:33

matkt linked an issue Oct 7, 2020 that may be closed by this pull request

Support Standard Bad Blocks JSON-RPC APIs #1357

Closed

bgravenorst self-assigned this Feb 11, 2021

alexandratran mentioned this pull request Sep 13, 2023

Add examples for debug methods ethereum/execution-apis#464

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add debug_getBadBlocks method #1378

Add debug_getBadBlocks method #1378

matkt commented Sep 11, 2020 •

edited

Loading

shemnon Sep 16, 2020

matkt Sep 16, 2020

shemnon Sep 16, 2020

matkt Sep 16, 2020 •

edited

Loading

shemnon Sep 16, 2020

shemnon Sep 16, 2020

matkt Sep 16, 2020

shemnon Sep 16, 2020

matkt Sep 16, 2020


		public class BadBlockManager {

		private final Map<Hash, Block> badBlocks = new ConcurrentHashMap<>();

Add debug_getBadBlocks method #1378

Add debug_getBadBlocks method #1378

Conversation

matkt commented Sep 11, 2020 • edited Loading

PR description

Request

Response

Test Performed on a local testnet :

Changelog

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matkt Sep 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matkt commented Sep 11, 2020 •

edited

Loading

matkt Sep 16, 2020 •

edited

Loading