Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Priv call #250

Merged
merged 23 commits into from
Jan 7, 2020
Merged

Priv call #250

merged 23 commits into from
Jan 7, 2020

Conversation

pinges
Copy link
Contributor

@pinges pinges commented Dec 12, 2019

PR description

Fixed Issue(s)

@pinges
Increase timeout to 5s
4f0d7e3 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges
Merge branch 'master' of github.com:hyperledger/besu into request_tim…
f20b412 
…eout
@pinges
add priv_call RPC
f9fa103 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges
add priv_call RPC
3ba6fed 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@lucassaldanha lucassaldanha added the privacy private transactions label Dec 17, 2019
lucassaldanha
lucassaldanha reviewed Dec 18, 2019
View reviewed changes
Copy link
Member

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is on the right track! I've added some comments and suggestions.

...um/core/src/main/java/org/hyperledger/besu/ethereum/privacy/PrivateTransactionSimulator.java Outdated Show resolved Hide resolved
...um/core/src/main/java/org/hyperledger/besu/ethereum/privacy/PrivateTransactionSimulator.java Outdated Show resolved Hide resolved
...sts/tests/src/test/java/org/hyperledger/besu/tests/web3j/privacy/PrivCallAcceptanceTest.java Outdated Show resolved Hide resolved
...sts/tests/src/test/java/org/hyperledger/besu/tests/web3j/privacy/PrivCallAcceptanceTest.java Outdated Show resolved Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/ProtocolSpecBuilder.java Show resolved Hide resolved
...n/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/privacy/methods/priv/PrivCall.java Outdated Show resolved Hide resolved
...n/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/privacy/methods/priv/PrivCall.java Show resolved Hide resolved
@lucassaldanha
Copy link
Member

@pinges we need to remove the updated ethereum/referencetests/src/test/resources directory from the changes in this commit.

pinges and others added 17 commits December 27, 2019 14:51
@pinges
merge upstream master
3ca0559 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges
fix spotless
8de4130 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges
fix ByteValues
81619e6 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges
Merge branch 'master' of github.com:hyperledger/besu into priv_call
409e517
@pinges
add multi tenancy membership check and additional AT
74472ad 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges
fix unit test
9f8e600 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges
fix unit test
48489b4 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges
fix unit test
741fa89 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges
fix unit test
e4912ca 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges
fix invalid privacy group AT
bf077a5 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges
Merge branch 'master' into priv_call
f269684
@pinges
add more ATs
39af6e8 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges
Merge branch 'priv_call' of github.com:pinges/besu into priv_call
956950f
@pinges
fix spotless
fe63a54 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges
suppress warning in AT
bad4dad 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges
Merge branch 'master' of github.com:hyperledger/besu into priv_call
97d8f79
@pinges
fix resource version
b53b6e3 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
CjHare
CjHare reviewed Jan 5, 2020
View reviewed changes
...sts/tests/src/test/java/org/hyperledger/besu/tests/web3j/privacy/PrivCallAcceptanceTest.java Outdated
}

@Test
public void privCallWithNonExistingPrivacyGroupMustNotSucceed() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

privCallWithoutExistingPrivacyGroupMustException
or
noExistingPrivacyGroupMustException
(as the class has the prefix PrivCall, also having as a method prefix seems redundant).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the test method names

CjHare
CjHare reviewed Jan 5, 2020
View reviewed changes
...org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/AbstractBlockParameterMethod.java
@@ -27,7 +27,7 @@

public abstract class AbstractBlockParameterMethod implements JsonRpcMethod {

private final Supplier<BlockchainQueries> blockchainQueries;
protected final Supplier<BlockchainQueries> blockchainQueries;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why widen the scope (encapsulation) instead of using the getter (getBlockchainQueries)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a short while we need access to this. When we add the mainnet functionality this can be set back to private. I have added a TODO for making this private again.

pinges and others added 2 commits January 6, 2020 18:52
@pinges
Merge branch 'master' into priv_call
90a168c
@pinges
addressed comments
20771de 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
@pinges pinges marked this pull request as ready for review January 6, 2020 23:42
lucassaldanha
lucassaldanha approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucassaldanha lucassaldanha merged commit 6e67988 into hyperledger:master Jan 7, 2020
@pinges pinges deleted the priv_call branch January 7, 2020 00:36
@MadelineMurray MadelineMurray mentioned this pull request Jan 31, 2020
Closed
edwardmack pushed a commit to ChainSafe/besu that referenced this pull request Feb 4, 2020
@pinges @edwardmack
Priv call (hyperledger#250)
205e4ff 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
edwardmack pushed a commit to ChainSafe/besu that referenced this pull request Feb 4, 2020
@pinges @edwardmack
Priv call (hyperledger#250)
3934462 
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
Signed-off-by: edwardmack <ed@edwardmack.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CjHare CjHare CjHare left review comments

@lucassaldanha lucassaldanha lucassaldanha approved these changes

Assignees
No one assigned
Labels
privacy private transactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinges @lucassaldanha @CjHare