Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build arm64 besu docker images #2954

Merged
merged 21 commits into from
May 9, 2022
Merged

Build arm64 besu docker images #2954

merged 21 commits into from
May 9, 2022

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Oct 26, 2021 •
edited
Loading

PR description

  • Add arm64 docker image building
  • add arch suffix to docker image publishing
  • add manifest task to create a unified docker manifest (arm64 and amd64) image publishing

Fixed Issue(s)

Changelog

garyschulte
garyschulte commented Oct 26, 2021
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@garyschulte garyschulte changed the title Build arm64 besu docker images Build arm64 besu docker images [WIP] Oct 27, 2021
@ajsutton
Copy link
Contributor

For the record, with Teku I wound up needing to use a machine executor and buildx to create the multi-arch docker image correctly. I don't think I ever found a way to get an ARM docker executor in CircleCI (I could get an arm container but the remote docker attached to it was still x86). Consensys/teku#4632 is the PR for Teku.

@macfarla macfarla mentioned this pull request Dec 9, 2021
Closed
@macfarla
Copy link
Contributor

@garyschulte - is this one superseded by #3481

@fab-10 fab-10 mentioned this pull request Apr 29, 2022
Closed
1 task
@garyschulte garyschulte reopened this May 4, 2022
@garyschulte garyschulte force-pushed the feature/arm64-docker branch 5 times, most recently from 30c693a to 51aca0d Compare May 6, 2022 08:09
@garyschulte garyschulte changed the title Build arm64 besu docker images [WIP] Build arm64 besu docker images May 6, 2022
@garyschulte garyschulte force-pushed the feature/arm64-docker branch from 4f717aa to cd3b5ac Compare May 6, 2022 08:29
shemnon
shemnon reviewed May 6, 2022
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
fab-10
fab-10 reviewed May 6, 2022
View reviewed changes
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
fab-10
fab-10 approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a CHANGELOG entry for this will be nice

macfarla
macfarla approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree a changelog entry would be good, otherwise LGTM

garyschulte added 8 commits May 9, 2022 10:28
@garyschulte
first pass at building arm64 besu docker images
97d0d17 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
rebase off main
8ca5262 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
use arm machine rather than docker
9734853 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
add arch to docker publish
f634591 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
rename branch for testing docker publish
744c94e 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
remove setup_remote_docker from arm64 publish pipeline
4252ff3 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
tyop
94ee468 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
remove manifestDocker task for now
6c88dae 
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte added 13 commits May 9, 2022 10:28
@garyschulte
add architecture envars to executors
0ea34cf 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
first pass at manifest docker
5d92343 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
setup docker in manifest step
1b22f25 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
fix manifest push command
2bb7e61 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
tweak perms, tweak platform
f1b647e 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
bump docker and cimg versions
c00d049 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
kiss
41d7e77 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
add base image to manifestDocker
a4ff317 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
all the tags!
6665d64 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
remove arm64-docker from branch filters
3376426 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
remove explicit jdk minor revision
c220287 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
use architecture envar to name and reference the goss executable
69799eb 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
add changelog
c35a922 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte force-pushed the feature/arm64-docker branch from 36e0e20 to c35a922 Compare May 9, 2022 17:29
@garyschulte garyschulte enabled auto-merge (squash) May 9, 2022 17:31
@garyschulte garyschulte merged commit 1efe1f0 into hyperledger:main May 9, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@garyschulte garyschulte mentioned this pull request May 11, 2022
Merged
2 tasks
@macfarla macfarla mentioned this pull request May 25, 2022
Open
@jframe jframe mentioned this pull request May 25, 2022
Closed
@garyschulte garyschulte deleted the feature/arm64-docker branch August 3, 2022 23:19
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@garyschulte @eum602
Build arm64 besu docker images (hyperledger#2954)
9e20279 
* first pass at building arm64 besu docker images
* add arch to docker publish
* add architecture envars to executors
* first pass at manifest docker
* setup docker in manifest step
* add base image to manifestDocker
* add changelog

Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shemnon shemnon shemnon approved these changes

@macfarla macfarla macfarla approved these changes

@fab-10 fab-10 fab-10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@garyschulte @ajsutton @macfarla @shemnon @fab-10