Improving backwards sync #3638
Merged
Improving backwards sync #3638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macfarla
reviewed
Apr 6, 2022
...e/src/test-support/java/org/hyperledger/besu/ethereum/core/ImMemoryBackwardChainFactory.java
Outdated
Show resolved
Hide resolved
.../eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/ForwardSyncPhase.java
Outdated
Show resolved
Hide resolved
gezero
force-pushed
the
improving-backwards-sync
branch
3 times, most recently
from
9d543a6 to
a593aec
Compare
gezero
force-pushed
the
improving-backwards-sync
branch
3 times, most recently
from
66ca12a to
f827634
Compare
jflo
approved these changes
Apr 12, 2022
...h/src/main/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardSyncContext.java
Show resolved
Hide resolved
...h/src/main/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardSyncContext.java
Outdated
Show resolved
Hide resolved
...h/src/main/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardSyncContext.java
Outdated
Show resolved
Hide resolved
...eth/src/test/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardChainTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardSyncContextTest.java
Show resolved
Hide resolved
garyschulte
requested changes
Apr 12, 2022
There was a problem hiding this comment.
short circuited my review while I look at resolving the conflict with #3696
besu/src/main/java/org/hyperledger/besu/controller/MergeBesuControllerBuilder.java
Show resolved
Hide resolved
garyschulte
approved these changes
Apr 13, 2022
gezero
force-pushed
the
improving-backwards-sync
branch
2 times, most recently
from
4d59b5b to
c1794d5
Compare
garyschulte
reviewed
Apr 13, 2022
besu/src/test/java/org/hyperledger/besu/controller/TransitionControllerBuilderTest.java
Outdated
Show resolved
Hide resolved
gezero
force-pushed
the
improving-backwards-sync
branch
3 times, most recently
from
4b466e1 to
9ebaad1
Compare
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> Abstracting the creation of BackwardChain into a factory Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> Improving coverage Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> Pivot should not be in constructor Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> Reverse the internal backward chain Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> Restarting after restart of backward sync improved Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> Backward chain completely stored on disk Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> Fixing tests Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> Looking for block is now a step instead of a service Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> Addressing review problems Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> Removing BackwardChainFactory as this abstraction is not needed anymore Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
gezero
force-pushed
the
improving-backwards-sync
branch
from
9ebaad1 to
c34dc82
Compare
|
Kudos, SonarCloud Quality Gate passed! |
gezero
added a commit
that referenced
this pull request
Apr 14, 2022
Refactor Backwards sync to use a rocks db. Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
matkt
pushed a commit
that referenced
this pull request
Apr 14, 2022
Refactor Backwards sync to use a rocks db. Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
May 2, 2022
Refactor Backwards sync to use a rocks db. Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
2 tasks
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Refactor Backwards sync to use a rocks db. Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation of backward sync only saved the headers and block bodies to disk. This PR combines the structure of backward sync chain into one dequeue, together with storing the chain on the disk.