-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set mainnet default gasLimit to 30M. Fixed #3767 #3768
Conversation
This would close Issue #3767 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually change the default gas for mainnet. It changes a block value in the genesis block of Ethereum Mainnet, which changes the hash of the genesis block, which breaks validation from the very first block.
This value must be 5000 (0x1388
hex), as shown here - https://etherscan.io/block/0
idk what do you think @shemnon but for me the gaslimit will increase automatically thanks to this https://github.com/hyperledger/besu/blob/ed1329cf848a9d7858d039a55add810da3c428b5/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/LondonTargetingGasLimitCalculator.java |
Thanks for the feedback. The documentation on the target-gas-limit CLI option states:
Does that update in the LondonTargetingGasLimitCalculator change to default gasLimit to whatever the mainnet is voting for? |
I need to check the interplay between this default and the targeting gas limit calculator for producing blocks, but I believe we currently have a hardcoded 30m gas limit for all post-merge blocks if it is otherwise unspecified: |
@garyschulte can we close this one since the gas limit is hardcoded? |
Update default gasLimit in preparation for The Merge™.