Remove deprecated EF bootnodes #5194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafael Matias <rafael@skyle.net>
skylenet
force-pushed
the
skylenet/remove-ef-deprecated-bootnodes
branch
from
e56bfaf
to
c364613
Compare
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
|
@skylenet hope you don't mind, I've added a small clean up to some of those json used for tests only. Thanks for sending pull request. |
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
|
@skylenet Could this have an impact on peering abilities for the regions affected? |
atoulme
approved these changes
Mar 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Not really as there's also the DNS discovery approach that should be preferred. |
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* Remove deprecated EF bootnodes Signed-off-by: Rafael Matias <rafael@skyle.net> * Remove unnecessary bootnode data from checkpoint json test * Remove ef deprecated bootnodes from genesis Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Rafael Matias <rafael@skyle.net> Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Remove deprecated EF bootnodes Signed-off-by: Rafael Matias <rafael@skyle.net> * Remove unnecessary bootnode data from checkpoint json test * Remove ef deprecated bootnodes from genesis Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Rafael Matias <rafael@skyle.net> Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Removed some deprecated EF bootnodes. The same nodes have been removed on geth: ethereum/go-ethereum#26828
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Acceptance Tests (Non Mainnet)
./gradlew acceptanceTestNonMainnetlocally if my PR affects non-mainnet modules.Changelog