Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gradle plugins and replace unmaintained license plugin #6275

Merged
merged 17 commits into from
Dec 18, 2023
Merged

Update Gradle plugins and replace unmaintained license plugin #6275

merged 17 commits into from
Dec 18, 2023

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Dec 11, 2023 •
edited
Loading

PR description

Update all the Gradle plugins to their latest version, and replace the unmaintained hierynomus.license plugin with the actively maintained Gradle License Report.
There are also few GHA Gradle cache optimizations.

Fixed Issue(s)

@fab-10
Update Gradle spotless plugin
fa5f38d 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10
Update Gradle plugin com.github.ben-manes.versions
41838d8 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10
Update Gradle plugin com.jfrog.artifactory
25fc970 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10
Update Gradle plugin io.spring.dependency-management
ce281d4 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10
Update Gradle plugin me.champeau.jmh
1646fae 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10
Update Gradle plugin net.ltgt.errorprone
58cc0db 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10
Update Gradle plugin org.sonarqube
c6ced92 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@github-actions GitHub Actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@fab-10
Clean verification metadata
2494ab0 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10
remove space
f9ff1a3 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10
Merge branch 'main' into update-gradle-plugins
f4d3760
@fab-10
Merge branch 'main' into update-gradle-plugins
3e4dc7c
@fab-10
More verification metadata
69a193b 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the update-gradle-plugins branch 3 times, most recently from e6fcf02 to cae6d80 Compare December 13, 2023 15:38
@fab-10
Tune GHA gradle cache + verification metadata
27d400d 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 changed the title Update Gradle plugins Update Gradle plugins + GHA setup Java action optimations Dec 13, 2023
@fab-10 fab-10 changed the title Update Gradle plugins + GHA setup Java action optimations Update Gradle plugins + GHA setup Java action optimizations Dec 13, 2023
@fab-10
Replace unmantained Gradle license plugin
fdc450c 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 changed the title Update Gradle plugins + GHA setup Java action optimizations Update Gradle plugins and replace unmaintained license plugin Dec 14, 2023
@fab-10
Merge branch 'main' into update-gradle-plugins
8f6b202
@fab-10
Update CHANGELOG
38fabd4 
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 marked this pull request as ready for review December 14, 2023 12:53
macfarla
macfarla approved these changes Dec 15, 2023
View reviewed changes
.github/workflows/codeql.yml
with:
distribution: adopt
distribution: 'temurin'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change related?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is part of the GHA opt, adopt is deprecated and replaced by "temurin", so updated to the latter everywhere

@fab-10 fab-10 enabled auto-merge (squash) December 18, 2023 09:37
@fab-10 fab-10 merged commit 1a7244f into hyperledger:main Dec 18, 2023
18 checks passed
@fab-10 fab-10 deleted the update-gradle-plugins branch December 18, 2023 10:10
jflo pushed a commit to jflo/besu that referenced this pull request Dec 18, 2023
@fab-10 @jflo
Update Gradle plugins and replace unmaintained license plugin (hyperl…
966c394 
…edger#6275)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: jflo <justin+github@florentine.us>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 18, 2023
@fab-10 @jflo
Update Gradle plugins and replace unmaintained license plugin (hyperl…
04247c9 
…edger#6275)


Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
jflo pushed a commit to jflo/besu that referenced this pull request Dec 18, 2023
@fab-10 @jflo
Update Gradle plugins and replace unmaintained license plugin (hyperl…
15ac7b6 
…edger#6275)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: jflo <justin+github@florentine.us>
jflo added a commit that referenced this pull request Dec 19, 2023
@jflo @shemnon
@matthew1001 @macfarla @dlutzardo @matkt @fab-10
Release 23.10.3-RC4 (#6310)
47364bf 
* Increase scope of reference tests (#6287)

Add new forks to transaction tests, add bad rlp to rlp ref tests.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: jflo <justin+github@florentine.us>

* Add trace to web socket JSON/RPC responses (#6285)

* Add trace to web socket JSON/RPC responses

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>

* Don't throw runtime exception if we can't parse JSON for trace

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>

---------

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>

* [MINOR] Include Enode URL in error message if parsing exception (#6288)

* include the actual Enode URL in the error message if IP can't be resolved

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>

* Execute the terminatedImmediately method only once (#6284)

Signed-off-by: David Lutzardo <jdlutzardo@izertis.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>

* move forest class to a specific package (#6293)

cleaning up the worldstate section, moving and renaming everything that is forest into a specific package in order to clarify the difference between Bonsai and Forest in the code.

---------

Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: matkt <karim.t2am@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>

* removed vintage junit dependency (#6296)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>

* updated cli and chainimport/export tests to junit 5 (#6281)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>

* [MINOR] CLI Subcommands migrate to junit 5 (#6282)

* updated cli and chainimport/export tests to junit 5

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* subcommands and besucommand test to junit5

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* removed duplicate line

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* removed vintage junit dep

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: jflo <justin+github@florentine.us>

* [MINOR] add genesis file name to config overview (#6297)

* add genesis file name to config overview

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>

* create trie package for bonsai and forest (#6300)

Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: matkt <karim.t2am@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>

* [MINOR] More cli tests to junit 5 (#6283)

* more CLI and services tests to junit5

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: jflo <justin+github@florentine.us>

* Update Gradle plugins and replace unmaintained license plugin (#6275)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: jflo <justin+github@florentine.us>

* Quick fix to avoid a tight loop when processing added blocks in txpool (#6309)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: jflo <justin+github@florentine.us>

* uprev to version 23.10.3-RC4

Signed-off-by: jflo <justin+github@florentine.us>

* mark deleted slot during clear storage step

Signed-off-by: Karim Taam <karim.t2am@gmail.com>

---------

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: jflo <justin+github@florentine.us>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: David Lutzardo <jdlutzardo@izertis.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: matkt <karim.t2am@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Co-authored-by: Matt Whitehead <matthew1001@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: David Lutzardo <jdlutzardo@izertis.com>
Co-authored-by: Karim TAAM <karim.t2am@gmail.com>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fab-10 @macfarla