Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release candidate 3 for 23.10.3 #6286

Merged
merged 27 commits into from
Dec 12, 2023
Merged

Release candidate 3 for 23.10.3 #6286

merged 27 commits into from
Dec 12, 2023

Commits on Dec 12, 2023

  1. Release 23.10.3 rc1 in progress, uprev main. (hyperledger#6227) 

    moving on to 23.10.4 developmnet

---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: jflo <justin+github@florentine.us>
    @jflo
    jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    4d21d5f View commit details
    Browse the repository at this point in the history

  2. New cli options to limit rewards return by eth_feeHistory (hyperledge… 

    …r#6202)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: jflo <justin+github@florentine.us>
    @Gabriel-Trintinalia @jflo
    Gabriel-Trintinalia authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    003ad3f View commit details
    Browse the repository at this point in the history

  3. [hyperledger#5851] Add error messages on authentication failures with… 

    … username and password (hyperledger#6212)

* Add error messages on authentication failures with username and password

Signed-off-by: David Lutzardo <jdlutzardo@izertis.com>

* Add a constant for the 'password'

Signed-off-by: David Lutzardo <jdlutzardo@izertis.com>

* Add test to check empty login and check response in body is not empty

Signed-off-by: David Lutzardo <jdlutzardo@izertis.com>

* Correct format (spotless)

Signed-off-by: David Lutzardo <jdlutzardo@izertis.com>

* Update ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceLoginTest.java

Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: David Lutzardo <jdlutzardo@izertis.com>

* Update ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceLoginTest.java

Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: David Lutzardo <jdlutzardo@izertis.com>

* Update JsonRpcHttpServiceLoginTest.java

use containsIgnoringCase

Signed-off-by: David Lutzardo <jdlutzardo@izertis.com>

* Add a CHANGELOG entry for PR 6212

Signed-off-by: David Lutzardo <jdlutzardo@izertis.com>

---------

Signed-off-by: David Lutzardo <jdlutzardo@izertis.com>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: jflo <justin+github@florentine.us>
    @dlutzardo @fab-10 @jflo
    2 people authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    da7ed76 View commit details
    Browse the repository at this point in the history

  4. Add RockDB Subcommand for printing usage per column family (hyperledg… 

    …er#6185)

* Add RockDB Subcommand for printing usage per column family
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

* changed output to follow a MD table notation.

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

---------

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @siladu @gfukushima @jflo
    2 people authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    4492c89 View commit details
    Browse the repository at this point in the history

  5. Deprecation warning if Forest pruning is enabled (hyperledger#6230) 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: jflo <justin+github@florentine.us>
    @fab-10 @jflo
    fab-10 authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    fc0b28a View commit details
    Browse the repository at this point in the history

  6. Fix the annoying "Errors occurred while build effective model" during… 

    … builds (hyperledger#6241)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: jflo <justin+github@florentine.us>
    @fab-10 @jflo
    fab-10 authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    c7f862a View commit details
    Browse the repository at this point in the history

  7. Run ATs sequentially (hyperledger#6244) 

    Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @gfukushima @jflo
    gfukushima authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    d4733f7 View commit details
    Browse the repository at this point in the history

  8. fix: double calls to trace{Start,End}Transaction (hyperledger#6247) 

    Signed-off-by: delehef <franklin.delehelle@odena.eu>
Signed-off-by: jflo <justin+github@florentine.us>
    @delehef @jflo
    delehef authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    68933f6 View commit details
    Browse the repository at this point in the history

  9. migrate to junit5 (hyperledger#6234) 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @macfarla @jflo
    macfarla authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    1249dae View commit details
    Browse the repository at this point in the history

  10. fixes for problems discovered in main (hyperledger#6248) 

    Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @garyschulte @jflo
    garyschulte authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    6e50479 View commit details
    Browse the repository at this point in the history

  11. Pki - migrate to junit 5 (hyperledger#6235) 

    * migrate to junit5

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* fix: double calls to trace{Start,End}Transaction (hyperledger#6247)

Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu>

* migrate to junit5 (hyperledger#6234)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* fixes for problems discovered in main (hyperledger#6248)

Signed-off-by: garyschulte <garyschulte@gmail.com>

* fixed test comparing size of collection

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: delehef <franklin.delehelle@odena.eu>
Co-authored-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @macfarla @delehef
    @garyschulte @jflo
    3 people authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    6aceb06 View commit details
    Browse the repository at this point in the history

  12. junit 5 ftw (hyperledger#6253) 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @macfarla @jflo
    macfarla authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    ea1a78b View commit details
    Browse the repository at this point in the history

  13. removed unnecessary use of static temp dir (hyperledger#6251) 

    * don't use static tempdir

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @macfarla @jflo
    macfarla authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    864d33e View commit details
    Browse the repository at this point in the history

  14. Remove parallelism usage from mainnet AT (hyperledger#6252) 

    * Remove parallelism usage from mainnet AT

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* Increase parallelism usage from mainnet AT

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* Add the split command back

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

---------

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @gfukushima @jflo
    gfukushima authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    ef2db43 View commit details
    Browse the repository at this point in the history

  15. fix log params (hyperledger#6254) 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @macfarla @pinges @jflo
    2 people authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    3ee481b View commit details
    Browse the repository at this point in the history

  16. add dependency on jar task (hyperledger#6255) 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @macfarla @jflo
    macfarla authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    6247ed3 View commit details
    Browse the repository at this point in the history

  17. Fix and test that the BlockAwareOperationTracer methods are invoked t… 

    …he correct number of times (hyperledger#6259)

* Test that the BlockAwareOperationTracer are invoked the correct number of times
* Remove redundant calls to traceEndBlock

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: jflo <justin+github@florentine.us>
    @fab-10 @jflo
    fab-10 authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    d981269 View commit details
    Browse the repository at this point in the history

  18. [RPC] Use apiConfiguration to limit gasPrice in eth_getGasPrice (hype… 

    …rledger#6243)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: jflo <justin+github@florentine.us>
    @Gabriel-Trintinalia @jflo
    Gabriel-Trintinalia authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    ce148f6 View commit details
    Browse the repository at this point in the history

  19. log bootnodes and static nodes list at debug level (hyperledger#6273) 

    * log bootnodes and static nodes list at debug level

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* log if zero bootnodes

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* null safeguards

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @macfarla @jflo
    macfarla authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    012b3db View commit details
    Browse the repository at this point in the history

  20. junit 5 (hyperledger#6256) 

    Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @macfarla @jflo
    macfarla authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    81aa191 View commit details
    Browse the repository at this point in the history

  21. Non bft group ats junit 5 (hyperledger#6260) 

    * migrate to junit 5

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @macfarla @jflo
    macfarla authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    e6c6e65 View commit details
    Browse the repository at this point in the history

  22. Txparse subcommand implementation (hyperledger#6268) 

    * txparse subcommand

Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @garyschulte @macfarla @jflo
    2 people authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    639236a View commit details
    Browse the repository at this point in the history

  23. [MINOR] migrate remaining Crypto tests to junit 5 (hyperledger#6280) 

    * update crypto tests to junit5

* fixed temp file

* removed vintage junit dep

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @macfarla @jflo
    macfarla authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    e39a9a4 View commit details
    Browse the repository at this point in the history

  24. add a fix to load correctly the storage trie in the Bonsai WorldState (… 

    …hyperledger#6205)

revert some modification that was made to pass tests hyperledger#5686 and fix this tests by loading the storage with EMPTY_TRIE_HASH if we detect that it has been cleared before pushing the new slots after recreation.

---------

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: matkt <karim.t2am@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @matkt @jflo
    matkt authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    45de1b0 View commit details
    Browse the repository at this point in the history

  25. Sequenced pool synonym for legacy pool (hyperledger#6274) 

    * Sequenced pool synonym for legacy pool

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>

* Class rename

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>

* Spotless fixes

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>

* Add SEQUENCED to config overview test

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Matt Whitehead <matthew1001@hotmail.com>

* add a fix to load correctly the storage trie in the Bonsai WorldState (hyperledger#6205)

revert some modification that was made to pass tests hyperledger#5686 and fix this tests by loading the storage with EMPTY_TRIE_HASH if we detect that it has been cleared before pushing the new slots after recreation.

---------

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

---------

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Matt Whitehead <matthew1001@hotmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: matkt <karim.t2am@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @matthew1001 @macfarla
    @matkt @jflo
    3 people authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    233f035 View commit details
    Browse the repository at this point in the history

  26. ETC mainnet 'Spiral' activation block (hyperledger#6267) 

    * Set ENR tree for DNS discovery for ETC mainnet network

Signed-off-by: Diego López León <dieguitoll@gmail.com>

* Set activation block number for ECIP-1109 on ETC mainnet

Signed-off-by: Diego López León <dieguitoll@gmail.com>

---------

Signed-off-by: Diego López León <dieguitoll@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
    @diega @jflo
    diega authored and jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    751efb5 View commit details
    Browse the repository at this point in the history

  27. uprev to version 23.10.3-RC3 

    Signed-off-by: jflo <justin+github@florentine.us>
    @jflo
    jflo committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    21f2fbc View commit details
    Browse the repository at this point in the history