Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict downgrade #6307

Merged
merged 23 commits into from
Feb 21, 2024
Merged

Restrict downgrade #6307

merged 23 commits into from
Feb 21, 2024

Commits on Dec 20, 2023

  1. Add Besu version to DB metadata. Check for downgrades and reject if v… 

    …ersion < version recorded in DB metadata.

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    32cb5fc View commit details
    Browse the repository at this point in the history

  2. Add --allow-downgrade CLI arg. If set it allows the downgrade and upd… 

    …ates the Besu version in the metadata file to the downgraded version.

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    723f268 View commit details
    Browse the repository at this point in the history

  3. Update gradle verification XML 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    494c8d3 View commit details
    Browse the repository at this point in the history

  4. Add and update tests 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    4520865 View commit details
    Browse the repository at this point in the history

  5. Refactoring 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    14014fa View commit details
    Browse the repository at this point in the history

  6. Remove versioning from RocksDB, now in separate VERSION_DATADATA.json 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    96f5080 View commit details
    Browse the repository at this point in the history

  7. Tidy up and tests for the new class 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    4c4b66b View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Move downgrade logic into VersionMetadata as BesuCommand is already v… 

    …ery big

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    ff03349 View commit details
    Browse the repository at this point in the history

  2. Add more tests 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    ee7a6ee View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into restrict-downgrade

    @matthew1001
    matthew1001 authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    30f395d View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Refactor the naming of the option to version-compatibility-protection 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    fb9e035 View commit details
    Browse the repository at this point in the history

  2. Remove remaining references to allow-downgrade 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    95370ab View commit details
    Browse the repository at this point in the history

  3. Rename test 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    383a7ba View commit details
    Browse the repository at this point in the history

  4. Update comments 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    719a174 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into restrict-downgrade 

    Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io>
    @matthew1001
    matthew1001 authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    32bae87 View commit details
    Browse the repository at this point in the history

  6. Metadata verification update 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    1526cd7 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. gradle fix 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    555ad6f View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Enable version downgrade protection by default for non-named networks 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    bc25ba7 View commit details
    Browse the repository at this point in the history

  2. Fix default logic 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    5d4db2a View commit details
    Browse the repository at this point in the history

  3. Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core… 

    …/VersionMetadata.java

Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Matt Whitehead <matthew1001@hotmail.com>
    @matthew1001 @fab-10
    matthew1001 and fab-10 authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    f2344d0 View commit details
    Browse the repository at this point in the history

  4. Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core… 

    …/VersionMetadata.java

Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Matt Whitehead <matthew1001@hotmail.com>
    @matthew1001 @fab-10
    matthew1001 and fab-10 authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    8a4ecb2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into restrict-downgrade 

    Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io>
    @matthew1001
    matthew1001 authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    a728e49 View commit details
    Browse the repository at this point in the history

  6. mock-maker-inline no longer needed 

    Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
    @matthew1001
    matthew1001 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    b828a37 View commit details
    Browse the repository at this point in the history