Added block add event. #637
Conversation
Added block reorg event. Added revert reason to both events. Signed-off-by: David Mechler <david.mechler@consensys.net>
| (event, chain) -> | ||
| listener.onBlockAdded( | ||
| blockAddedContext( | ||
| event.getBlock()::getHeader, |
There was a problem hiding this comment.
Wow... that compiled? I didn't know that was possible.
|
|
||
| /** A transaction receipt, containing information pertaining a transaction execution. */ | ||
| public interface TransactionReceipt { | ||
| Optional<Bytes> getRevertReason(); |
There was a problem hiding this comment.
I think we should add the 4 fields listed in section 4.3.1 of the yellow paper: cumulativeGasUsed, logs, bloomFilter, and status. For bloomFilter I think we want to just expose the Bytes object rather than our LogBloomFilter. If we get covariant type complaints from Java we can just create a new method (BloomFilterBytes) and cast it down., but for the other three we can just expose the existing methods, since we have Log already as a data type.
Also, they all the methods need javadoc. RevertReason is our own field so we should mention it's data beyond what the yellow paper requires, but for the other four just stick with the simple definitions.
Signed-off-by: David Mechler <david.mechler@consensys.net>
Signed-off-by: David Mechler <david.mechler@consensys.net>
PR description
Added block add event.
Added block reorg event.
Added revert reason to block add event.
Signed-off-by: David Mechler david.mechler@consensys.net
Fixed Issue(s)