Introduce TransactionEvaluationContext to pass data between selectors and plugin #6381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and plugin (hyperledger#30) * Introduce TransactionSelectionContext to pass data between selectors Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Use TransactionSelectionContext in all the methods of the plugin selector Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
|
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @param transactionSelectionResult The transaction selection result | ||
| */ | ||
| default void onTransactionNotSelected( | ||
| final PendingTransaction pendingTransaction, | ||
| final TransactionEvaluationContext<? extends PendingTransaction> evaluationContext, |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * @param processingResult The result of processing the selected transaction. | ||
| */ | ||
| default void onTransactionSelected( | ||
| final PendingTransaction pendingTransaction, | ||
| final TransactionEvaluationContext<? extends PendingTransaction> evaluationContext, |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * @param processingResult the transaction processing result | ||
| * @return TransactionSelectionResult that indicates whether to include the transaction | ||
| */ | ||
| TransactionSelectionResult evaluateTransactionPostProcessing( | ||
| PendingTransaction pendingTransaction, TransactionProcessingResult processingResult); | ||
| TransactionEvaluationContext<? extends PendingTransaction> evaluationContext, |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * @param processingResult the transaction processing result | ||
| * @return TransactionSelectionResult that indicates whether to include the transaction | ||
| */ | ||
| TransactionSelectionResult evaluateTransactionPostProcessing( | ||
| PendingTransaction pendingTransaction, TransactionProcessingResult processingResult); | ||
| TransactionEvaluationContext<? extends PendingTransaction> evaluationContext, | ||
| TransactionProcessingResult processingResult); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * @return TransactionSelectionResult that indicates whether to include the transaction | ||
| */ | ||
| TransactionSelectionResult evaluateTransactionPreProcessing( | ||
| PendingTransaction pendingTransaction); | ||
| TransactionEvaluationContext<? extends PendingTransaction> evaluationContext); |
Check notice
Code scanning / CodeQL
Useless parameter Note
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Some tx selector plugins needs more context about the current tx being evaluated, for example the current minGasPrice, or the effective price of the tx and possibly more data in the future, for this we introduce the TransactionEvaluationContext to hold that data and pass it across all the selectors and the plugin. Another advantage of this context is to avoid to compute multiple time the same data, in case it is needed in more that one selector.
Fixed Issue(s)