-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote block txs selection max time options to stable #6423
Merged
fab-10
merged 8 commits into
hyperledger:main
from
fab-10:stabilize-block-txs-selection-max-time-options
Jan 18, 2024
Merged
Promote block txs selection max time options to stable #6423
fab-10
merged 8 commits into
hyperledger:main
from
fab-10:stabilize-block-txs-selection-max-time-options
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fab-10
changed the title
Stabilize block txs selection max time options
Promote block txs selection max time options to stable
Jan 17, 2024
fab-10
added
the
doc-change-required
Indicates an issue or PR that requires doc to be updated
label
Jan 17, 2024
fab-10
force-pushed
the
stabilize-block-txs-selection-max-time-options
branch
from
January 17, 2024 14:11
5e4909e
to
9269ba7
Compare
pinges
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
…sactions during block creation are now stable Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
stabilize-block-txs-selection-max-time-options
branch
from
January 18, 2024 08:52
121b542
to
ffab513
Compare
bgravenorst
removed
the
doc-change-required
Indicates an issue or PR that requires doc to be updated
label
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Promote block txs selection max time options to stable.
Both options were introduced in #6044, and are working fine since them, with the promotion the hard caps have been removed since that could be an issue with existing networks that are used to have longer block creation times.
Fixed Issue(s)