Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote block txs selection max time options to stable #6423

Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Jan 17, 2024

PR description

Promote block txs selection max time options to stable.
Both options were introduced in #6044, and are working fine since them, with the promotion the hard caps have been removed since that could be an issue with existing networks that are used to have longer block creation times.

Fixed Issue(s)

Copy link

github-actions bot commented Jan 17, 2024

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@fab-10 fab-10 changed the title Stabilize block txs selection max time options Promote block txs selection max time options to stable Jan 17, 2024
@fab-10 fab-10 added the doc-change-required Indicates an issue or PR that requires doc to be updated label Jan 17, 2024
@fab-10 fab-10 force-pushed the stabilize-block-txs-selection-max-time-options branch from 5e4909e to 9269ba7 Compare January 17, 2024 14:11
@fab-10 fab-10 marked this pull request as ready for review January 17, 2024 19:03
Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
…sactions during block creation are now stable

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the stabilize-block-txs-selection-max-time-options branch from 121b542 to ffab513 Compare January 18, 2024 08:52
@fab-10 fab-10 enabled auto-merge (squash) January 18, 2024 08:53
@fab-10 fab-10 merged commit 2d7941f into hyperledger:main Jan 18, 2024
18 checks passed
@fab-10 fab-10 deleted the stabilize-block-txs-selection-max-time-options branch January 18, 2024 13:58
@bgravenorst bgravenorst removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants