Fix poa-block-txs-selection-max-time option that was inadvertently reset to its default after being configured
#6444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fab-10
force-pushed
the
fix-poa-block-txs-selection-max-time
branch
6 times, most recently
from
de8b0bb
to
8aab6e7
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
fix-poa-block-txs-selection-max-time
branch
from
8aab6e7
to
fef14d5
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
changed the title
poa-block-txs-selection-max-time option that was inadvertently reset to its default after being configured
macfarla
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fix
poa-block-txs-selection-max-timeoption that was inadvertently reset to its default after being configured.Mining options needs the value of the block period from the genesis file, so the way to pass it to the class has been improved to avoid using the mining options if that value was not set, in order to be less error prone.
Fixed Issue(s)