-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore bws sync requests until initial sync is complete #6455
Merged
garyschulte
merged 3 commits into
hyperledger:main
from
garyschulte:bugfix/ignore-bws-until-initial-sync-complete
Jan 24, 2024
Merged
ignore bws sync requests until initial sync is complete #6455
garyschulte
merged 3 commits into
hyperledger:main
from
garyschulte:bugfix/ignore-bws-until-initial-sync-complete
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
noticed while testing:
|
garyschulte
force-pushed
the
bugfix/ignore-bws-until-initial-sync-complete
branch
from
January 24, 2024 14:00
ab4c75f
to
8c29d68
Compare
Changed to return failed future rather than completed null future for BWS sync requests when BWS is not ready. |
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
bugfix/ignore-bws-until-initial-sync-complete
branch
from
January 24, 2024 17:46
8c29d68
to
5be17b4
Compare
jflo
approved these changes
Jan 24, 2024
garyschulte
added a commit
to garyschulte/besu
that referenced
this pull request
Jan 24, 2024
…6455) * ignore bws sync requests until initial sync is complete * return failed Future when BWS is invoked but not ready Signed-off-by: garyschulte <garyschulte@gmail.com>
Merged
garyschulte
added a commit
that referenced
this pull request
Jan 26, 2024
jframe
added a commit
to jframe/besu
that referenced
this pull request
Mar 18, 2024
…rledger#6455)" This reverts commit ed1480b. Signed-off-by: Jason Frame <jason.frame@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Ensure we do not attempt to start BWS sessions if initial sync has not yet completed. This change prevents BWS from triggering via engine-api during:
Fixed Issue(s)