Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore bws sync requests until initial sync is complete #6455

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Jan 23, 2024

PR description

Ensure we do not attempt to start BWS sessions if initial sync has not yet completed. This change prevents BWS from triggering via engine-api during:

  • initial sync
  • auto-heal
  • resync worldstate

Fixed Issue(s)

Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@garyschulte
Copy link
Contributor Author

noticed while testing:

{"@timestamp":"2024-01-24T01:46:36,934","level":"WARN","thread":"vert.x-worker-thread-0","class":"MergeCoordinator","message":"Internal error, backward sync completed but failed to import finalized block 0x96d1bee095e8c72586e2eeaf374d169e200865d3c4fced88abb0de949167b9b6","throwable":""}
{"@timestamp":"2024-01-24T01:46:48,500","level":"WARN","thread":"vert.x-worker-thread-0","class":"MergeCoordinator","message":"Internal error, backward sync completed but failed to import finalized block 0x96d1bee095e8c72586e2eeaf374d169e200865d3c4fced88abb0de949167b9b6","throwable":""}

@garyschulte garyschulte force-pushed the bugfix/ignore-bws-until-initial-sync-complete branch from ab4c75f to 8c29d68 Compare January 24, 2024 14:00
@garyschulte
Copy link
Contributor Author

backward sync completed but failed to import finalized block

Changed to return failed future rather than completed null future for BWS sync requests when BWS is not ready.

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte force-pushed the bugfix/ignore-bws-until-initial-sync-complete branch from 8c29d68 to 5be17b4 Compare January 24, 2024 17:46
@garyschulte garyschulte enabled auto-merge (squash) January 24, 2024 20:31
@garyschulte garyschulte merged commit ed1480b into hyperledger:main Jan 24, 2024
18 checks passed
@garyschulte garyschulte deleted the bugfix/ignore-bws-until-initial-sync-complete branch January 24, 2024 21:36
garyschulte added a commit to garyschulte/besu that referenced this pull request Jan 24, 2024
…6455)

* ignore bws sync requests until initial sync is complete
* return failed Future when BWS is invoked but not ready

Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte mentioned this pull request Jan 24, 2024
garyschulte added a commit that referenced this pull request Jan 26, 2024
* silence dns query error warning, at least until we can demote the upstream log to DEBUG (#6458)
* ignore bws sync requests until initial sync is complete (#6455)
* release 24.1.1

Signed-off-by: garyschulte <garyschulte@gmail.com>
jframe added a commit to jframe/besu that referenced this pull request Mar 18, 2024
…rledger#6455)"

This reverts commit ed1480b.

Signed-off-by: Jason Frame <jason.frame@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants