-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pragueTime configuration #6473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wire through configuration for the Prague fork, including speculative PragueGasCalculator, precompiles, and genesis options. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
|
Acceptance test is timeout related. Works for me lcoally... when the tests set the timeout is 900 seconds :P Once I get approvals I'll figure out where to increase the timeout. |
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
When a genesis only has cancunTime at genesis and no shanghai time, it implies that shanghai transitions at the same time. Update 'at genesis' logic to look at the next sequential mainnet fork to determine if 'at genesis' triggered. Update 6110 tests that exhibited incorrect behavior, which now serves as an 'implied at genesis' test. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
siladu
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just the possible mistake in the PragueGasCalculator as per comments.
evm/src/main/java/org/hyperledger/besu/evm/gascalculator/PragueGasCalculator.java
Outdated
Show resolved
Hide resolved
evm/src/main/java/org/hyperledger/besu/evm/gascalculator/PragueGasCalculator.java
Outdated
Show resolved
Hide resolved
evm/src/main/java/org/hyperledger/besu/evm/gascalculator/PragueGasCalculator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jan 30, 2024
Wire through configuration for the Prague fork, including speculative PragueGasCalculator, precompiles, genesis options, and implied forks in GenesisState. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jan 30, 2024
Wire through configuration for the Prague fork, including speculative PragueGasCalculator, precompiles, genesis options, and implied forks in GenesisState. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jan 30, 2024
Wire through configuration for the Prague fork, including speculative PragueGasCalculator, precompiles, genesis options, and implied forks in GenesisState. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Wire through configuration for the Prague fork, including speculative PragueGasCalculator, precompiles, and genesis options.
Fixed Issue(s)