Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pragueTime configuration #6473

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Jan 26, 2024

PR description

Wire through configuration for the Prague fork, including speculative PragueGasCalculator, precompiles, and genesis options.

Fixed Issue(s)

Wire through configuration for the Prague fork, including speculative
PragueGasCalculator, precompiles, and genesis options.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@shemnon
Copy link
Contributor Author

shemnon commented Jan 27, 2024

Acceptance test is timeout related. Works for me lcoally... when the tests set the timeout is 900 seconds :P

Once I get approvals I'll figure out where to increase the timeout.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
When a genesis only has cancunTime at genesis and no shanghai time, it
implies that shanghai transitions at the same time. Update 'at genesis'
logic to look at the next sequential mainnet fork to determine if
'at genesis' triggered.  Update 6110 tests that exhibited incorrect
behavior, which now serves as an 'implied at genesis' test.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just the possible mistake in the PragueGasCalculator as per comments.

shemnon and others added 4 commits January 29, 2024 08:47
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon shemnon enabled auto-merge (squash) January 30, 2024 18:07
@shemnon shemnon merged commit 098d997 into hyperledger:main Jan 30, 2024
18 checks passed
jflo pushed a commit to jflo/besu that referenced this pull request Jan 30, 2024
Wire through configuration for the Prague fork, including speculative
PragueGasCalculator, precompiles, genesis options, and implied
forks in GenesisState.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
jflo pushed a commit to jflo/besu that referenced this pull request Jan 30, 2024
Wire through configuration for the Prague fork, including speculative
PragueGasCalculator, precompiles, genesis options, and implied
forks in GenesisState.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
jflo pushed a commit to jflo/besu that referenced this pull request Jan 30, 2024
Wire through configuration for the Prague fork, including speculative
PragueGasCalculator, precompiles, genesis options, and implied
forks in GenesisState.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants